From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755458AbdKNOFq (ORCPT ); Tue, 14 Nov 2017 09:05:46 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:43926 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbdKNOFi (ORCPT ); Tue, 14 Nov 2017 09:05:38 -0500 Date: Tue, 14 Nov 2017 15:05:34 +0100 From: Ralf Baechle To: Matt Redfearn Cc: James Hogan , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman Subject: Re: [PATCH] MIPS: ath25: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE Message-ID: <20171114140534.GA14698@linux-mips.org> References: <1510666157-27252-1-git-send-email-matt.redfearn@mips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510666157-27252-1-git-send-email-matt.redfearn@mips.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 01:29:17PM +0000, Matt Redfearn wrote: > Currently MIPS allnoconfig with CONFIG_ATH25=y fails to link due to > missing support for early_serial_setup(): > > LD vmlinux > arch/mips/ath25/devices.o: In function ath25_serial_setup': > devices.c:(.init.text+0x68): undefined reference to 'early_serial_setup' > > Rather than adding dependencies to the platform to force inclusion of > SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM, > etc, just make ath25_serial_setup() a no-op when the dependency is not > selected in the kernel config. Looks like arch/mips/rb532/serial.c might be suffering from the same issue? Ralf