public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, patches@groups.riscv.org,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	peterz@infradead.org
Subject: Re: [GIT PULL] RISC-V Port for Linux 4.15 v9
Date: Tue, 14 Nov 2017 19:23:08 +0000	[thread overview]
Message-ID: <20171114192307.GA17509@arm.com> (raw)
In-Reply-To: <mhng-1ea3f488-332b-49dd-a32e-8c97c8caa4b2@palmer-si-x1c4>

Hi Palmer,

On Mon, Nov 13, 2017 at 01:56:22PM -0800, Palmer Dabbelt wrote:
> The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4:
> 
>   Linux 4.14 (2017-11-12 10:46:13 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git tags/riscv-for-linus-4.15-arch-v9
> 
> for you to fetch changes up to 512d88db5ef3de56f392f761657c2ab2cadc0498:
> 
>   Merge tag 'v4.14' into for-linus (2017-11-13 13:17:51 -0800)

[...]

>       RISC-V: Atomic and Locking Code

I had some open comments on this patch:

http://lkml.kernel.org/r/20171024141032.GD13445@arm.com

Amongst other things, you're adding a spin_unlock_wait and I think your
test bitops are missing barriers.

I'm not suggesting this holds up the merge, but a reply would've been
nice :/

Will

  parent reply	other threads:[~2017-11-14 19:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 21:56 [GIT PULL] RISC-V Port for Linux 4.15 v9 Palmer Dabbelt
2017-11-14  9:04 ` Arnd Bergmann
2017-11-14 16:00   ` Palmer Dabbelt
2017-11-14 19:23 ` Will Deacon [this message]
2017-11-14 19:27   ` Palmer Dabbelt
2017-11-15 18:51 ` Linus Torvalds
2017-11-15 19:21   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171114192307.GA17509@arm.com \
    --to=will.deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=palmer@dabbelt.com \
    --cc=patches@groups.riscv.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox