From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756241AbdKNUXI (ORCPT ); Tue, 14 Nov 2017 15:23:08 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33444 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754894AbdKNUXA (ORCPT ); Tue, 14 Nov 2017 15:23:00 -0500 Date: Tue, 14 Nov 2017 21:22:49 +0100 From: Heiko Carstens To: Greg Kroah-Hartman Cc: linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, Julian Wiedmann , Ursula Braun , Thomas Gleixner , Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH 5/9] s390: net: add SPDX identifiers to the remaining files References: <20171114173808.25092-1-gregkh@linuxfoundation.org> <20171114173808.25092-6-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114173808.25092-6-gregkh@linuxfoundation.org> X-TM-AS-GCONF: 00 x-cbid: 17111420-0012-0000-0000-0000058D4739 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111420-0013-0000-0000-000019080295 Message-Id: <20171114202249.GA3059@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711140269 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 06:38:04PM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/s390/net/ files with the correct SPDX license > identifier based on the license text in the file itself. The SPDX > identifier is a legally binding shorthand, which can be used instead of > the full boiler plate text. > > This work is based on a script and data from Thomas Gleixner, Philippe > Ombredanne, and Kate Stewart. > > Cc: Julian Wiedmann > Cc: Ursula Braun > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- > diff --git a/drivers/s390/net/fsm.c b/drivers/s390/net/fsm.c > index 8c14c6c3ad3d..f0c7c182b077 100644 > --- a/drivers/s390/net/fsm.c > +++ b/drivers/s390/net/fsm.c > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: GPL-2.0 > /** > * A generic FSM based on fsm used in isdn4linux > * What's the rationale to add GPL-2.0 to this file? This seems to be a bit confusing since this file has no explicit license template, except this one: MODULE_LICENSE("GPL"); Which, according to include/linux/module.h translates to "GPL" [GNU Public License v2 or later] On the other hand there are files like drivers/s390/char/zcore.c which just contain a statement "License: GPL", which was converted to GPL-1.0+ (see patch 4 of this series). Right now I'm not saying that anything is wrong here, but I'd like to understand the rationale.