From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754995AbdKOCp3 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 21:45:29 -0500
Received: from mga07.intel.com ([134.134.136.100]:15135 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751226AbdKOCpU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 21:45:20 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,397,1505804400"; 
   d="scan'208";a="5069182"
Date: Tue, 14 Nov 2017 18:44:31 -0800
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
        Tony Luck <tony.luck@intel.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>, x86@kernel.org,
        ricardo.neri@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 3/4] x86/umip: Identify the str and sldt
 instructions
Message-ID: <20171115024431.GA10377@voyager>
References: <1510640985-18412-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <1510640985-18412-4-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <20171114072157.f4knhqouiflj5drr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171114072157.f4knhqouiflj5drr@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 14, 2017 at 08:21:57AM +0100, Ingo Molnar wrote:
> 
> * Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
> 
> > The instructions STR and SLDT are not emulated in any case. Thus, it made
> > sense to not implement functionality to identify them. However, a
> > subsequent commit will introduce functionality to warn about the use of
> > all the instructions that UMIP protect, not only those that are emulated.
> > A first step for that is the ability to identify them.
> > 
> > Plus, now that STR and SLDT are identified, we need to explicitly avoid
> > their emulation (i.e., not rely on unsuccessful identification). Group
> > togehter all the cases that we do not want to emulate: STR, SLDT and user
> > long mode processes.
> > 
> > Cc: Andy Lutomirski <luto@kernel.org>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Ravi V. Shankar <ravi.v.shankar@intel.com>
> > Cc: x86@kernel.org
> > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> 
> Sigh, the _title_ still refers to 'str'...
> 
> I'll fix it up, no need to resend, but this lack of attention to details is 
> seriously sad.

I apologize for the oversight. I focused on the code and changelog. Thanks for
fixing it!

Thanks and BR,
Ricardo