From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753437AbdKOHYD (ORCPT ); Wed, 15 Nov 2017 02:24:03 -0500 Received: from mail-pg0-f51.google.com ([74.125.83.51]:52636 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbdKOHXz (ORCPT ); Wed, 15 Nov 2017 02:23:55 -0500 X-Google-Smtp-Source: AGs4zMbg27FTwc9wXMA80BRAea7PxDO/ZniCTb2S4CLGu1a402HkgzrTB4Q8pIDDpRXGo0v6WFSPQQ== Date: Tue, 14 Nov 2017 23:23:51 -0800 From: Bjorn Andersson To: Christophe JAILLET Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] remoteproc: qcom: Fix error handling paths in order to avoid memory leaks Message-ID: <20171115072351.GC22677@builder> References: <20171115065835.14525-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171115065835.14525-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 14 Nov 22:58 PST 2017, Christophe JAILLET wrote: > In case of error returned by 'q6v5_xfer_mem_ownership', we must free > some resources before returning. > > In 'q6v5_mpss_init_image()', add a new label to undo a previous > 'dma_alloc_attrs()'. > In 'q6v5_mpss_load()', re-use the already existing error handling code to > undo a previous 'request_firmware()', as already done in the other error > handling paths of the function. > > Signed-off-by: Christophe JAILLET Thanks! Regards, Bjorn