From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: akpm@linux-foundation.org, corbet@lwn.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples: replace FSF address with web source in license notices
Date: Wed, 15 Nov 2017 09:45:41 +0100 [thread overview]
Message-ID: <20171115084541.GA23833@kroah.com> (raw)
In-Reply-To: <19e33c22c64218d4fca53871f3408871@posteo.de>
On Wed, Nov 15, 2017 at 08:46:51AM +0100, Martin Kepplinger wrote:
> Am 15.11.2017 07:29 schrieb Greg KH:
> > On Tue, Nov 14, 2017 at 10:50:37AM +0100, Martin Kepplinger wrote:
> > > A few years ago the FSF moved and "59 Temple Place" is wrong. Having
> > > this
> > > still in our source files feels old and unmaintained.
> > >
> > > Let's take the license statement serious and not confuse users.
> > >
> > > As https://www.gnu.org/licenses/gpl-howto.html suggests, we replace
> > > the
> > > postal address with "<http://www.gnu.org/licenses/>" in the samples
> > > directory.
> >
> > What would be best is to just put the SPDX single line at the top of the
> > files, and then remove this license "boilerplate" entirely. I've
> > started to do that with some subsystems already (drivers/usb/ and
> > drivers/tty/ are almost finished, see Linus's tree for details), and
> > I've sent out a patch series for drivers/s390/ yesterday if you want to
> > see an example of how to do it.
> >
> > Could you do that here instead of this patch as well?
> >
>
> Is there consensus about this? I'm not a layer, but is this clear enough for
> useres? And what holds against only adding the new SPDX tag line at the top?
What do you mean by "adding a new" line? That would change the license
of the file, so don't do that :)
And yes, a single SPDX line in the file is determined to be a valid
legal mark of the license of the file according to all of the lawyers I
have been working with from lots of different companies. See the last
s390 patch series for one such example of that.
> Other than I don't like mixing // and /**/ comments, it indeed looks
> quite clean. Is there consensus about the syntax too?
See the patch series from Thomas on lkml for the syntax format, the
"consensus" was driven by Linus :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-15 8:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 9:50 [PATCH] samples: replace FSF address with web source in license notices Martin Kepplinger
2017-11-15 6:29 ` Greg KH
2017-11-15 7:46 ` Martin Kepplinger
2017-11-15 8:45 ` Greg KH [this message]
2017-11-15 20:44 ` [PATCH] samples: replace outdated permission statement with SPDX identifiers Martin Kepplinger
2017-11-16 11:41 ` Greg KH
2017-11-17 22:53 ` Jonathan Corbet
2017-11-17 23:43 ` Martin Kepplinger
2017-11-18 0:13 ` Jonathan Corbet
2017-11-18 8:33 ` Martin Kepplinger
2017-11-18 10:20 ` Greg KH
2017-11-18 10:17 ` Greg KH
2017-11-18 11:21 ` Martin Kepplinger
2017-11-16 13:56 ` Philippe Ombredanne
2017-11-22 22:23 ` [PATCH] samples: replace FSF address with web source in license notices Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115084541.GA23833@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox