From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757275AbdKOJWr (ORCPT ); Wed, 15 Nov 2017 04:22:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42756 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755194AbdKOJWl (ORCPT ); Wed, 15 Nov 2017 04:22:41 -0500 Date: Wed, 15 Nov 2017 10:22:43 +0100 From: Greg Kroah-Hartman To: Heiko Carstens Cc: linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, Julian Wiedmann , Ursula Braun , Thomas Gleixner , Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH 5/9] s390: net: add SPDX identifiers to the remaining files Message-ID: <20171115092243.GC800@kroah.com> References: <20171114173808.25092-1-gregkh@linuxfoundation.org> <20171114173808.25092-6-gregkh@linuxfoundation.org> <20171114202249.GA3059@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114202249.GA3059@osiris> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 09:22:49PM +0100, Heiko Carstens wrote: > On Tue, Nov 14, 2017 at 06:38:04PM +0100, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/s390/net/ files with the correct SPDX license > > identifier based on the license text in the file itself. The SPDX > > identifier is a legally binding shorthand, which can be used instead of > > the full boiler plate text. > > > > This work is based on a script and data from Thomas Gleixner, Philippe > > Ombredanne, and Kate Stewart. > > > > Cc: Julian Wiedmann > > Cc: Ursula Braun > > Cc: Martin Schwidefsky > > Cc: Heiko Carstens > > Cc: Thomas Gleixner > > Cc: Kate Stewart > > Cc: Philippe Ombredanne > > Signed-off-by: Greg Kroah-Hartman > > --- > > diff --git a/drivers/s390/net/fsm.c b/drivers/s390/net/fsm.c > > index 8c14c6c3ad3d..f0c7c182b077 100644 > > --- a/drivers/s390/net/fsm.c > > +++ b/drivers/s390/net/fsm.c > > @@ -1,3 +1,4 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > /** > > * A generic FSM based on fsm used in isdn4linux > > * > > What's the rationale to add GPL-2.0 to this file? This seems to be a bit > confusing since this file has no explicit license template, except this > one: > > MODULE_LICENSE("GPL"); > > Which, according to include/linux/module.h translates to > "GPL" [GNU Public License v2 or later] > > On the other hand there are files like drivers/s390/char/zcore.c which just > contain a statement "License: GPL", which was converted to GPL-1.0+ (see > patch 4 of this series). > Right now I'm not saying that anything is wrong here, but I'd like to > understand the rationale. For any files with no explicit license in them, like this one, the "implicit" license of GPL-2.0 is assumed. See commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") in Linus's tree for a full description of this, where we converted all in-tree files at the time that did not have a explicit license in it. It seems this file missed that initial commit, sorry, I don't know how that happened, especially as this file has been in the tree for a very very long time. Philippe, any ideas how we missed this file in the previous large sweep? thanks, greg k-h