From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758872AbdKOTYR (ORCPT ); Wed, 15 Nov 2017 14:24:17 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:56246 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbdKOTYF (ORCPT ); Wed, 15 Nov 2017 14:24:05 -0500 X-Google-Smtp-Source: AGs4zMbNQtR3xhys4GnVvPgKed/D3W3jlVVYi+7p4vIw9KmOfyKtr+g5RG3RWe3dzvAFQh/oX59sYg== Date: Wed, 15 Nov 2017 17:23:59 -0200 From: Gustavo Padovan To: Liviu Dudau Cc: Brian Starkey , David Airlie , LKML , DRI-devel , Mali DP Maintainers , Daniel Vetter Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure. Message-ID: <20171115192359.GA5486@jade> References: <20171101141317.3052-1-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171101141317.3052-1-Liviu.Dudau@arm.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liviu, 2017-11-01 Liviu Dudau : > The malidp_hw_device structure that the driver uses to handle the > differences between versions of the IP contains both non-changeable > data and fields that get updated at probe time. Previously we were > copying the read-only part into allocated memory, but that can be > completely avoided by splitting the structure into a read-only part > and keeping the runtime modifiable fields into the old structure. > > Reviewed-by: Brian Starkey > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/arm/malidp_crtc.c | 13 ++++---- > drivers/gpu/drm/arm/malidp_drv.c | 30 ++++++++--------- > drivers/gpu/drm/arm/malidp_hw.c | 46 ++++++++++++++------------ > drivers/gpu/drm/arm/malidp_hw.h | 65 ++++++++++++++++++++++--------------- > drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------ > 5 files changed, 93 insertions(+), 80 deletions(-) Reviewed-by: Gustavo Padovan Gustavo