From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758772AbdKOWue (ORCPT ); Wed, 15 Nov 2017 17:50:34 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:51000 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758700AbdKOWu0 (ORCPT ); Wed, 15 Nov 2017 17:50:26 -0500 Date: Wed, 15 Nov 2017 22:49:50 +0000 From: Roman Gushchin To: David Rientjes CC: Michal Hocko , , Andrew Morton , Johannes Weiner , Mike Kravetz , "Aneesh Kumar K.V" , Andrea Arcangeli , Dave Hansen , , Subject: Re: [PATCH] mm: show total hugetlb memory consumption in /proc/meminfo Message-ID: <20171115224941.GA4286@castle> References: <20171114125026.7055-1-guro@fb.com> <20171114131736.v2m6alrt5gelmh5c@dhcp22.suse.cz> <20171115081818.ucnp26tho4qffdwx@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:180::1:5328] X-ClientProxiedBy: VI1PR09CA0073.eurprd09.prod.outlook.com (2603:10a6:802:29::17) To SN2PR15MB1086.namprd15.prod.outlook.com (2603:10b6:804:22::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3f0e510-d591-4710-d6b6-08d52c7b3681 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:SN2PR15MB1086; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;3:GWAP6lD3LibirzaBUk4Ms+cTa65ag8Xgq+iTKEek/+Zcpxmhp2teXOxS0U5gMl+g2afM3KrDBygUn8JvbRBIwnosoWt019owONhP04LP/H1Px/1ayNU1GiufXFLkrDL/jn1YqbQG3KNAQl09wQTUL1krMy8MsIZLh6inAOmuo+XAVDKfLOK1WipQCwdnYrfqVpAHST1kSomjdDo22mFYjbPAR3PQShjn9Qif72Jbv4JxP2XqLCQgRy9OHjLEer1p;25:MlyHaI/pdPWA8yuBOuPwCNepsME6aVrwQhf37hA9jLRGAY66uBQF4fhl6EfIx3d9QixD4RFJiKmumbA9NI4lL4x8gva0vKkLef3hF/OSNQvUej5n8sygdMOwqRiiA9F9nwGewlM+KTZuzKKyyX35SHYcGjaFcKltN3DBZBL8M30ajsOMcCm32UxrQ5U9rXCIYjG59UBnEQ2uekX4KxvdioXplsF4MiMKYIPBRtJmEeuExykobWAMyR3oyBB2juy6PEDMV/+l9E7mpCI+NrEGhvF3q4n9OTxriEPAPirlX1NPWWkyahO5/LpswE4ScRqDkZ6utVTWIuIfFLuwjfSrtQ==;31:S7B3VPo3Oh8z5n/6xZE545tc6fc7SC0ShicA2pAHYeDVloEV79xsJ4DdkH6cVAbsbwTtbFueHEoPB9K38qps98sHVS9v2pZv8JzKcl4sBeWysl15hIT7dNf/TyX2VsaDGYK1Hfj4Cx0kVHAH219a36ydjiWynrMsXXMLF6D73GGNMI8wic3694UYuDfbEKF4iEIsaP9WmdDfw1boRLnm/xm7PTWsm7Z5Svd6rOt9Fys= X-MS-TrafficTypeDiagnostic: SN2PR15MB1086: X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;20:mbzLulVN/+jKpgixGt5Fw8eg+apPQIJsePKfOvbwyx9LozGgJA3MkFDLuTj9dXe1fthZxPZiVsnx2BkuQEpd0o9KDPz4HcRIrVb+3P27Dx1B/WlwO/I4lOwtq9TXmEhJsknTXpFLC8VqSoaemkNQskZIK7WpVECo7Kr3dcMsOyG7YpB6SZMAI70LPfl5pMM7Jv4dwsMhO66PSg8n2OZWXd7GvRpKpfDCZ2yfB7qstalNeLUyMBGqZXQAFolaXnogk/LGddvyVhe1sBLTjFpMeQFGelLhYA33lMf8coPBQg/GQFGwZV3wBPGO8lepoYCA+sGlsFQXdmo8ax3VgEKiwsgRZQPgUM6ppZrZLACQ3bVD/lsC7HUbRc0wYRorNwnkzRE8zqo2OQhCZ9qABeHdbB/h/aW4POMuuQNd87ZGxgQT6ydehFH4fHPz/T5V/+jdksrOVsZjb3w6VrlbQ9adQEGJ7rO4DzBku+J15qgZMfG+drpzLATD04oLBGxytrsM;4:7qrrFS8DlmWoyEEcU8UbHFOuJcwO+TEj0DdJakjLWcskgCpJ1K5+IguG7B2ZNfmbySeb8djCf9ichiJLnVTAc5Uw9oGNaVCtIYAShL9c6LoY+QWkLFv+e22jgTOU5WNtRM+dea8cQhYteE0TiO6CJRii1Slsrk1qQDJ/Ik4KR+pwOwJaGSM3ivtNqQEyvsFQGD+QhaPBowxQSG+xdKSoVQsEno4WDyJkFPkBjSuHXTQ4EZp49InICVam/PRvBUbU85bpG4u32RiNNNttK8tobQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3231022)(3002001)(6041248)(20161123560025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN2PR15MB1086;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN2PR15MB1086; X-Forefront-PRVS: 0492FD61DD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(189002)(199003)(24454002)(106356001)(8936002)(6246003)(6496005)(53936002)(9686003)(316002)(4326008)(54906003)(58126008)(16586007)(97736004)(478600001)(93886005)(105586002)(25786009)(86362001)(7736002)(8676002)(83506002)(23726003)(33716001)(305945005)(47776003)(101416001)(1076002)(2906002)(6116002)(55016002)(6666003)(2950100002)(81166006)(81156014)(33656002)(50986999)(54356999)(6916009)(68736007)(76176999)(7416002)(189998001)(229853002)(50466002)(5660300001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB1086;H:castle;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB1086;23:ZYcszfV8GxvKaCbBJCLj7ryZdBhhux01txGIE+E31?= =?us-ascii?Q?zug8/2UIHUu9108T1nyXgL5iSkXwKQT5qXPNo/mQ/of7YT5IXD3l7fFuxSI1?= =?us-ascii?Q?lz5A5E6GMi7rvaND2K6M5ZKSeG7DS0iLLuDdsU/sgHyeGGrVdDsyXVk29rn5?= =?us-ascii?Q?XIx60pqzhfsN8eQ6+uMZ9qeH1+Le91AzdoXKUwPFYTBTcMyr6XQdFDcfIvVm?= =?us-ascii?Q?gR5AT2qpFEYZ1j7kJ/wRkfW2DhczVIJ9ucO+S9n5TBAqv53PDnRpKP+HyjfU?= =?us-ascii?Q?wlqLn7bv4uPAvrOSSxmAqNjrVqCGD+09nogyEo8alxgo/XIAGg7lT/TJOrCW?= =?us-ascii?Q?ZMjb3iPprnxhny2HxCpktHP3fwYpW1wPW1pOJavxURZQIyHqbtaFolO0jkkn?= =?us-ascii?Q?f5SSxSUB/DToGWE1Lw3MEHMMHdeBmxkploym4yfxDXW3EGGrbDXtNV+9h7az?= =?us-ascii?Q?/Xg9/olNqQJU3bvixC491A4cXMAypDOpluU3f3e5YVVEKsg/aOYPSC9G8wn9?= =?us-ascii?Q?yqp0F2S+kmmaehFkxckHgKGHKUHfAVak6JxoGku3ybVa7jVGo2M2Bz7Hnny8?= =?us-ascii?Q?TsCF2jsYEmpbeIh8Xhv6PWoVzhX3BC2sUXyoNYAZWUuW48b3YGMwoZoPZTZi?= =?us-ascii?Q?jEhuWTuzSoectsp9S3MASjJm7pdVSZhbrqUaaiJLsQBDqp/gW0xXVA+XNIVW?= =?us-ascii?Q?gvz0RHMJfBy0nGZ/R/IBH0Pfe0iqBUxdCIRBKzPIcolwJTihg7zlciHOMEJX?= =?us-ascii?Q?IfFvtFLgYPo/32cvQSsNg8Fh/75qTG3K6Xd6E6nH91tkD7aEohQDQvD/VWbs?= =?us-ascii?Q?/8q9Avuw/4Ixu4F193Z2Woz82SA3jj3vq4xLORRLFj9T5oBlnSsjQxPvGRaj?= =?us-ascii?Q?hHOyVd56DLOKXde6t94C8/lzIigAjuMJr9PcH5CJ+sTklcAe80ST+pUCcI1v?= =?us-ascii?Q?avNHrsld5wMnH1oxNwsj1bpVpw8gXsS1cjtoviBaf5JhIi0qLNlZwKs5SpHK?= =?us-ascii?Q?iqSHuYuPX0DKf538NC7ISIFl3SasPwWEZLBUMRoJBoClCQthm2e1YpbBAov7?= =?us-ascii?Q?RY8KaWaG1YJzKddbH7Aa93Ya7raI3SUe/gX03DaFknyd2iKYYaVqWgTcogch?= =?us-ascii?Q?Kk9yEoPpx/Iqs3IkuWRVbYtec7lP1ApawMJdDQD5/Xm59y6a3emNRWX5DIm2?= =?us-ascii?Q?hVnb7OHxRTuzxzFFW39PS9sVnvSZKB0fJci?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;6:cDXNH1n2sF8oVYzFZ4ZTvdLMPz66SEwyEXLc8tk9WrjDEIJbMic29nTqiCsob8SEdtAlYmkttQ3TIJmrceeddE3HL1y86ELAm+vqCb9WeuYICwE9qVkj+wuSe98B2Py8ZYzoxQcxgBVY6m2WCKelaJXT+d1oBM7ZI+/cgl/Qz0T8HVWlhsjfw3YUu9RzJo7lRy6DTE/5WpmqZMpl90H1V6tpkNYxwWZd9Fs00dG5KgqMkgP++w91pWsndsyMTRAHLHreYsZQG7jimii33bjfU1NFHfYCH908+ROVeqCiU/tiZOB7zwNEodwett33Ls1swAoJiVE1Wr0tjYHcexMgKjT+0MwhadHJKxpE+0UF9TY=;5:kCNya/Q2BajQWmukpHpvKDzHpDU321TYQ5L3Yi4hytGIu1c8Rm7u4WO3weIt4dGbH1EDBDT7w4045BhsWH2yrleNwi/Lzc5meCSb1XVRI6+rIDCtuOwRBUVbbs8weIRdojXgJ1PQcAZV6MJoHRVKf8VbC0DyfOfW6s+B7UNd2zY=;24:Za2qIH6rNxQXEojkCYTOAeX8Iz6Du+kakY2drT4lq5M2ZW+q52QSpeF/lt/MRJNh6ysXfjSnAUhObcJYJpMIlLxw6v+BS+HovyvRcIgG2Hw=;7:eoxtC/Fn2xt45uXWnTmTA/JDtG53/co/9sVTNQ/RogSY8Z7GYhHuwkvnA4Qy5ECI6gDNGhUQu8I+fPiSIXY7bqpK+vifDaHFgHsTcSx752x9axbmdoXOoE9UQkMD1AaWrUm7IEdWq2+wbCNlTvG/LaIxXDgrcvrBmW+xhocE04k/no0NS91xejBlLzub1DCB1BXPCwSeYmijmHRbM2nLG/ny/wuYxO2giOfD+024X99jTF7rDChowQtC4Ek7Dbzi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1086;20:43gx1W2D62LRm64zhN8lyCyqKtRSehNBwK+1Ae1sYh94bG6M1WlFvv6h/OcBJ81quydrKqfyd/oPxDB1nJ755DT1R91cKHiRyPPChCoKkq2UUl2PXHBjf8sRiXPxvVpr1CszRlCzNgEt8Zd1iNwdgSEXsSwn8/VKCtFLO8D3Gcs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2017 22:50:02.3464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3f0e510-d591-4710-d6b6-08d52c7b3681 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB1086 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-15_11:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2017 at 02:46:00PM -0800, David Rientjes wrote: > On Wed, 15 Nov 2017, Michal Hocko wrote: > > > > > > if (!hugepages_supported()) > > > > > return; > > > > > seq_printf(m, > > > > > @@ -2987,6 +2989,11 @@ void hugetlb_report_meminfo(struct seq_file *m) > > > > > h->resv_huge_pages, > > > > > h->surplus_huge_pages, > > > > > 1UL << (huge_page_order(h) + PAGE_SHIFT - 10)); > > > > > + > > > > > + for_each_hstate(h) > > > > > + total += (PAGE_SIZE << huge_page_order(h)) * h->nr_huge_pages; > > > > > > > > Please keep the total calculation consistent with what we have there > > > > already. > > > > > > > > > > Yeah, and I'm not sure if your comment eludes to this being racy, but it > > > would be better to store the default size for default_hstate during the > > > iteration to total the size for all hstates. > > > > I just meant to have the code consistent. I do not prefer one or other > > option. > > It's always nice when HugePages_Total * Hugepagesize cannot become greater > than Hugetlb. Roman, could you factor something like this into your > change accompanied with a documentation upodate as suggested by Dave? Hi David! Working on it... I'll post an update soon. Thanks!