From: Shawn Guo <shawnguo@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node
Date: Thu, 16 Nov 2017 16:39:21 +0800 [thread overview]
Message-ID: <20171116083920.GK25384@dragon> (raw)
In-Reply-To: <1510147805-24873-1-git-send-email-ioana.ciornei@nxp.com>
On Wed, Nov 08, 2017 at 03:30:05PM +0200, Ioana Ciornei wrote:
> Add the fsl-mc node in the LS1088A device tree.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 62 ++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index bd80e9a..aa37ffe 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -166,6 +166,68 @@
> <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
> };
>
> + fsl_mc: fsl-mc@80c000000 {
The unit-address of the node should be somehow related to 'reg'
property. Can you please help me understand how they are related?
> + compatible = "fsl,qoriq-mc";
> + reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> + <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> + msi-parent = <&its>;
> + #address-cells = <3>;
> + #size-cells = <1>;
> +
> + /*
> + * Region type 0x0 - MC portals
> + * Region type 0x1 - QBMAN portals
> + */
> + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> +
> + dpmacs {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dpmac1: dpmac@1 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <1>;
> + };
Please have a newline in between nodes.
Shawn
> + dpmac2: dpmac@2 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <2>;
> + };
> + dpmac3: dpmac@3 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <3>;
> + };
> + dpmac4: dpmac@4 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <4>;
> + };
> + dpmac5: dpmac@5 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <5>;
> + };
> + dpmac6: dpmac@6 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <6>;
> + };
> + dpmac7: dpmac@7 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <7>;
> + };
> + dpmac8: dpmac@8 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <8>;
> + };
> + dpmac9: dpmac@9 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <9>;
> + };
> + dpmac10: dpmac@10 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xa>;
> + };
> + };
> + };
> +
> psci {
> compatible = "arm,psci-0.2";
> method = "smc";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-11-16 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 13:30 [PATCH] arm64: dts: ls1088a: add fsl-mc hardware resource manager node Ioana Ciornei
2017-11-16 8:39 ` Shawn Guo [this message]
2017-11-16 14:24 ` Ioana Ciornei
2017-11-17 12:35 ` Shawn Guo
2017-11-17 13:59 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116083920.GK25384@dragon \
--to=shawnguo@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox