From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933693AbdKPIDa (ORCPT ); Thu, 16 Nov 2017 03:03:30 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47188 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933564AbdKPIDV (ORCPT ); Thu, 16 Nov 2017 03:03:21 -0500 Date: Thu, 16 Nov 2017 09:03:14 +0100 From: Martin Schwidefsky To: Kees Cook Cc: Heiko Carstens , Harald Freudenberger , linux-s390@vger.kernel.org, LKML , Thomas Gleixner Subject: Re: [PATCH] s390/ap_bus: Convert timers to use timer_setup() In-Reply-To: References: <20171025102737.GA145851@beast> <20171026083842.5ca46b2f@mschwideX1> <20171103072926.12ef827c@mschwideX1> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17111608-0040-0000-0000-0000040EF0A2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111608-0041-0000-0000-000020B1AA71 Message-Id: <20171116090314.36ded7c5@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-16_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711160109 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Nov 2017 23:58:44 -0800 Kees Cook wrote: > On Thu, Nov 2, 2017 at 11:29 PM, Martin Schwidefsky > wrote: > > On Thu, 2 Nov 2017 16:36:53 -0700 > > Kees Cook wrote: > > > >> On Wed, Oct 25, 2017 at 11:38 PM, Martin Schwidefsky > >> wrote: > >> > On Wed, 25 Oct 2017 03:27:37 -0700 > >> > Kees Cook wrote: > >> > > >> >> In preparation for unconditionally passing the struct timer_list pointer to > >> >> all timer callbacks, switch to using the new timer_setup() and from_timer() > >> >> to pass the timer pointer explicitly. > >> >> > >> >> Cc: Harald Freudenberger > >> >> Cc: Martin Schwidefsky > >> >> Cc: Heiko Carstens > >> >> Cc: linux-s390@vger.kernel.org > >> >> Signed-off-by: Kees Cook > >> >> --- > >> >> drivers/s390/crypto/ap_bus.c | 10 +++++----- > >> >> drivers/s390/crypto/ap_bus.h | 2 +- > >> >> drivers/s390/crypto/ap_queue.c | 2 +- > >> >> 3 files changed, 7 insertions(+), 7 deletions(-) > >> > > >> > Parked for the second part of the s390 updates for the next merge window. > >> > Thanks. > >> > >> Thanks for getting these staged. I just wanted to check with you, > >> since I don't see these in -next anywhere yet: > >> > >> s390: qdio: Convert timers to use timer_setup() > >> s390/sclp: Convert timers to use timer_setup() > >> s390/cio: Convert timers to use timer_setup() > >> s390/scsi: Convert timers to use timer_setup() > >> s390/ap_bus: Convert timers to use timer_setup() > >> > >> Are all of these expected to land for -rc1? (Would it help to carry > >> them in the timer tree?) I've got tree-wide changes ready to go once > >> all these conversions have landed. > > > > These patches are parked on a private branches. The features branch > > on s390/linux is the one that is used for -next AND for the upstream > > merge. And since I do not want to rebase that branch the timer_setup > > patches are not in -next as well. > > > > Four of you patches are safe with me, the s390/scsi patch is in > > Steffens patch queue. All good I would say. > > Hi, > > I saw s390 get merged for -rc1, but none of these timer_setup() > conversions were included. Given the possible short merge window, > what's the state of these? I can't do the bulk API changes at the end > of -rc1 without the s390 timer patches. Anything I can help with? The remaining timer_setup changes are on the features branch of s390/linux, I plan to send a please-pull request be the end of the week. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.