public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <linux-kernel-dev@beckhoff.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Patrick Bruenn <p.bruenn@beckhoff.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
	<linux-rtc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Juergen Borleis <jbe@pengutronix.de>,
	Noel Vellemans <Noel.Vellemans@visionbms.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: [PATCH] Documentation: dt: rtc-imxdi: imx53-rtc is not compatible
Date: Thu, 16 Nov 2017 10:34:25 +0100	[thread overview]
Message-ID: <20171116093425.32145-1-linux-kernel-dev@beckhoff.com> (raw)

From: Patrick Bruenn <p.bruenn@beckhoff.com>

rtc-imxdi driver is not compatible with imx53-rtc like the example
suggested.
Only the raw timestamp register offsets match by accident, which has the
effect, that during startup/shutdown system clock syncronization with
rtc seems to work for imx53, too.
However hwclock and rtctest, will not work as expected on imx53.
To avoid future reverts like [1], we should adjust the documentation.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/542312.html

Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>

---

To: Alessandro Zummo <a.zummo@towertech.it>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM)
Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: linux-kernel@vger.kernel.org (open list)
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Juergen Borleis <jbe@pengutronix.de>
Cc: Noel Vellemans <Noel.Vellemans@visionbms.com>
Cc: Shawn Guo <shawnguo@kernel.org>
---
 Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
index 323cf26374cb..af853b0ceac5 100644
--- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
+++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
@@ -1,6 +1,6 @@
 * i.MX25 Real Time Clock controller
 
-This binding supports the following chips: i.MX25, i.MX53
+This binding supports the following chips: i.MX25
 
 Required properties:
 - compatible: should be: "fsl,imx25-rtc"
@@ -14,7 +14,7 @@ Optional properties:
 Example:
 
 rtc@80056000 {
-	compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
+	compatible = "fsl,imx25-rtc";
 	reg = <0x80056000 2000>;
 	interrupts = <29 56>;
 };
-- 
2.11.0

             reply	other threads:[~2017-11-16  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  9:34 linux-kernel-dev [this message]
2017-11-16  9:44 ` [PATCH] Documentation: dt: rtc-imxdi: imx53-rtc is not compatible Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116093425.32145-1-linux-kernel-dev@beckhoff.com \
    --to=linux-kernel-dev@beckhoff.com \
    --cc=Noel.Vellemans@visionbms.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=jbe@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=p.bruenn@beckhoff.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox