From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759551AbdKPOOq (ORCPT ); Thu, 16 Nov 2017 09:14:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:39934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbdKPOOj (ORCPT ); Thu, 16 Nov 2017 09:14:39 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B949214EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 16 Nov 2017 11:14:33 -0300 From: Arnaldo Carvalho de Melo To: Sihyeon Jang Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH] perf kmem: Change a word from migratetype to migrate_type for unity Message-ID: <20171116141433.GT8836@kernel.org> References: <1510839706-7762-1-git-send-email-uneedsihyeon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510839706-7762-1-git-send-email-uneedsihyeon@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Nov 16, 2017 at 10:41:46PM +0900, Sihyeon Jang escreveu: > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Sihyeon Jang Please describe the problem and why such word change is warranted. Its not enough to say what is being done, you need to say _why_. And this seems bogus, look: { "kmem:mm_page_alloc", perf_evsel__process_page_alloc_event, }, So that function handles: [root@jouet ~]# grep field.*migrate /sys/kernel/debug/tracing/events/kmem/mm_page_alloc/format field:int migratetype; offset:24; size:4; signed:1; [root@jouet ~]# The field is not named "migrate_type", so your change will _break_ the 'perf kmem' tool, not good :-) - Arnaldo > --- > tools/perf/builtin-kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 557d391..43858cd 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -786,7 +786,7 @@ static int perf_evsel__process_page_alloc_event(struct perf_evsel *evsel, > unsigned int order = perf_evsel__intval(evsel, sample, "order"); > unsigned int gfp_flags = perf_evsel__intval(evsel, sample, "gfp_flags"); > unsigned int migrate_type = perf_evsel__intval(evsel, sample, > - "migratetype"); > + "migrate_type"); > u64 bytes = kmem_page_size << order; > u64 callsite; > struct page_stat *pstat; > -- > 2.7.4