From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935563AbdKPPNN (ORCPT ); Thu, 16 Nov 2017 10:13:13 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:45993 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934834AbdKPPNG (ORCPT ); Thu, 16 Nov 2017 10:13:06 -0500 X-Google-Smtp-Source: AGs4zMYM97ALh0zBIKMn6lqBU5O2VZvEiWcqgASqnGLzz9+i1DYw5ZJtnhnZsoju9PlNAe3ZxTSqRw== Date: Thu, 16 Nov 2017 07:13:02 -0800 From: Bjorn Andersson To: Arun Kumar Neelakantam Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: smp2p: Access APCS as mailbox client Message-ID: <20171116151302.GN28761@minitux> References: <20171116071832.7441-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16 Nov 04:17 PST 2017, Arun Kumar Neelakantam wrote: > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c [..] > > + smp2p->mbox_client.dev = &pdev->dev; > > + smp2p->mbox_chan = mbox_request_channel(&smp2p->mbox_client, 0); > any reason why we are not using "knows_txdone = true" for SMP2P but using > for only SMD drivers That's a mistake by me, will update the patch. Thanks, Bjorn