From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934083AbdKPQLU (ORCPT ); Thu, 16 Nov 2017 11:11:20 -0500 Received: from mga07.intel.com ([134.134.136.100]:29584 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759341AbdKPQLL (ORCPT ); Thu, 16 Nov 2017 11:11:11 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,404,1505804400"; d="scan'208";a="176993481" Date: Thu, 16 Nov 2017 21:44:26 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, mark.rutland@arm.com, michael.opdenacker@free-electrons.com, poeschel@lemonage.de, andreas.noever@gmail.com, arnd@arndb.de, bp@suse.de, devicetree@vger.kernel.org, james.hogan@imgtec.com, pawel.moll@arm.com, linux-arm-msm@vger.kernel.org, sharon.dvir1@mail.huji.ac.il, robh+dt@kernel.org, sdharia@codeaurora.org, alan@linux.intel.com, treding@nvidia.com, mathieu.poirier@linaro.org, jkosina@suse.cz, linux-kernel@vger.kernel.org, daniel@ffwll.ch, joe@perches.com, davem@davemloft.net Subject: Re: [alsa-devel] [PATCH v7 03/13] slimbus: Add SLIMbus bus type Message-ID: <20171116161426.GA3187@localhost> References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org> <20171115141043.29202-4-srinivas.kandagatla@linaro.org> <20171116131814.GV3187@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 01:40:05PM +0000, Srinivas Kandagatla wrote: > On 16/11/17 13:18, Vinod Koul wrote: > >On Wed, Nov 15, 2017 at 02:10:33PM +0000, srinivas.kandagatla@linaro.org wrote: > > > >>+menuconfig SLIMBUS > >>+ tristate "Slimbus support" > >>+ help > >>+ Slimbus is standard interface between System-on-Chip and audio codec, > >>+ and other peripheral components in typical embedded systems. > >>+ > >>+ If unsure, choose N. > >>+ > >>+if SLIMBUS > >>+ > >>+# SlIMbus controllers > > > >Slimbus perhaps? > > > slimbus is specified as "SLIMbus" in the mipi specs, so I should probably > stay with it and make it consistent across the patchset. Yeah this I though was a first use, so I though this was a typo. I think Documentation should use the spec term (like SoundWire) and code should pick anyone and just be consistent on it. > >>+static int slim_device_match(struct device *dev, struct device_driver *drv) > >>+{ > >>+ struct slim_device *sbdev = to_slim_device(dev); > >>+ struct slim_driver *sbdrv = to_slim_driver(drv); > >>+ > >>+ return slim_match(sbdrv->id_table, sbdev) != NULL; > > > >return !!slim_match() ? I guess you missed this one.. > >>+struct slim_device_id { > >>+ __u16 manf_id, prod_code; > >>+ __u8 dev_index, instance; > >>+ > >>+ /* Data private to the driver */ > >>+ kernel_ulong_t driver_data; > > > >As Takashi pointed out in SDW patches, this needs to be aligned. > > > Okay, I will make sure that driver_data is aligned. You may want to look at comments and disucssion on the SoundWire patches -- ~Vinod