public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Todd Kjos <tkjos@android.com>
Cc: Todd Kjos <tkjos@google.com>, Arve Hj??nnev??g <arve@android.com>,
	devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
	Martijn Coenen <maco@google.com>
Subject: Re: [PATCH] binder: fix proc->files use-after-free
Date: Thu, 16 Nov 2017 18:52:57 +0100	[thread overview]
Message-ID: <20171116175257.GA30594@kroah.com> (raw)
In-Reply-To: <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>

On Thu, Nov 16, 2017 at 09:48:13AM -0800, Todd Kjos wrote:
> > @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
> >  static void binder_free_proc(struct binder_proc *proc);
> >  static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
> >
> > +struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> This should be declared static:
>   static struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> Greg- should I send a "v2" for this?

Please do, I can't do anything with these until after 4.15-rc1 is out,
so you have time to do it :)

thanks,

greg k-h

      reply	other threads:[~2017-11-16 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15  1:06 [PATCH] binder: fix proc->files use-after-free Todd Kjos
2017-11-16 17:48 ` Todd Kjos
2017-11-16 17:52   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116175257.GA30594@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@google.com \
    --cc=tkjos@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox