From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966264AbdKPRyq (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Nov 2017 12:54:46 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:38330 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1759833AbdKPRwz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Nov 2017 12:52:55 -0500
Date: Thu, 16 Nov 2017 18:52:57 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Todd Kjos <tkjos@android.com>
Cc: Todd Kjos <tkjos@google.com>, Arve Hj??nnev??g <arve@android.com>,
        devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>
Subject: Re: [PATCH] binder: fix proc->files use-after-free
Message-ID: <20171116175257.GA30594@kroah.com>
References: <20171115010629.32859-1-tkjos@google.com>
 <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 16, 2017 at 09:48:13AM -0800, Todd Kjos wrote:
> > @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
> >  static void binder_free_proc(struct binder_proc *proc);
> >  static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
> >
> > +struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> This should be declared static:
>   static struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> Greg- should I send a "v2" for this?

Please do, I can't do anything with these until after 4.15-rc1 is out,
so you have time to do it :)

thanks,

greg k-h