* [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use
@ 2017-11-15 20:21 Mario Limonciello
2017-11-16 3:55 ` valdis.kletnieks
2017-11-17 1:52 ` Darren Hart
0 siblings, 2 replies; 3+ messages in thread
From: Mario Limonciello @ 2017-11-15 20:21 UTC (permalink / raw)
To: dvhart, Andy Shevchenko
Cc: LKML, platform-driver-x86, valdis.kletnieks, Mario Limonciello
On machines using rfkill interface the buffer needs to have been
allocated before the initial use (memset) of it.
Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
drivers/platform/x86/dell-laptop.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index c4903c5..2d70436 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -2073,6 +2073,11 @@ static int __init dell_init(void)
if (ret)
goto fail_platform_device2;
+ buffer = kzalloc(sizeof(struct calling_interface_buffer), GFP_KERNEL);
+ if (!buffer)
+ goto fail_buffer;
+
+
ret = dell_setup_rfkill();
if (ret) {
@@ -2080,10 +2085,6 @@ static int __init dell_init(void)
goto fail_rfkill;
}
- buffer = kzalloc(sizeof(struct calling_interface_buffer), GFP_KERNEL);
- if (!buffer)
- goto fail_buffer;
-
if (quirks && quirks->touchpad_led)
touchpad_led_init(&platform_device->dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use
2017-11-15 20:21 [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use Mario Limonciello
@ 2017-11-16 3:55 ` valdis.kletnieks
2017-11-17 1:52 ` Darren Hart
1 sibling, 0 replies; 3+ messages in thread
From: valdis.kletnieks @ 2017-11-16 3:55 UTC (permalink / raw)
To: Mario Limonciello; +Cc: dvhart, Andy Shevchenko, LKML, platform-driver-x86
On Wed, 15 Nov 2017 14:21:13 -0600, Mario Limonciello said:
> On machines using rfkill interface the buffer needs to have been
> allocated before the initial use (memset) of it.
>
> Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
> drivers/platform/x86/dell-laptop.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Works here, thanks. Feel free to stick a Tested-By: on it ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use
2017-11-15 20:21 [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use Mario Limonciello
2017-11-16 3:55 ` valdis.kletnieks
@ 2017-11-17 1:52 ` Darren Hart
1 sibling, 0 replies; 3+ messages in thread
From: Darren Hart @ 2017-11-17 1:52 UTC (permalink / raw)
To: Mario Limonciello
Cc: Andy Shevchenko, LKML, platform-driver-x86, valdis.kletnieks
On Wed, Nov 15, 2017 at 02:21:13PM -0600, Mario Limonciello wrote:
> On machines using rfkill interface the buffer needs to have been
> allocated before the initial use (memset) of it.
>
> Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Queued, thanks Valdis and Mario.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-17 1:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-15 20:21 [PATCH] platform/x86: dell-laptop: Allocate buffer before rfkill use Mario Limonciello
2017-11-16 3:55 ` valdis.kletnieks
2017-11-17 1:52 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox