From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755852AbdKQCoO (ORCPT ); Thu, 16 Nov 2017 21:44:14 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37662 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755785AbdKQCoG (ORCPT ); Thu, 16 Nov 2017 21:44:06 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4F42360856 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 16 Nov 2017 18:44:04 -0800 From: Stephen Boyd To: Randy Dunlap Cc: Rob Herring , Frank Rowand , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] of: Document exactly what of_find_node_by_name() puts Message-ID: <20171117024404.GV11955@codeaurora.org> References: <20171111014536.3592-1-sboyd@codeaurora.org> <0ef4b415-801c-cb58-5de1-01bcfba1c778@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ef4b415-801c-cb58-5de1-01bcfba1c778@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Signed-off-by: Stephen Boyd > > --- > > drivers/of/base.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index 63897531cd75..602c5d65734a 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node > > * @from: The node to start searching from or %NULL; the node > > > * you pass will not be searched, only the next one > > * will; typically, you pass what the previous call > > * will. Typically, you pass what the previous call > Rob, do you want me to fold this in? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project