From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934019AbdKQHH6 (ORCPT ); Fri, 17 Nov 2017 02:07:58 -0500 Received: from mga09.intel.com ([134.134.136.24]:16757 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933950AbdKQHHt (ORCPT ); Fri, 17 Nov 2017 02:07:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,407,1505804400"; d="scan'208";a="6006581" Date: Fri, 17 Nov 2017 12:41:05 +0530 From: Vinod Koul To: srinivas.kandagatla@linaro.org Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, mark.rutland@arm.com, michael.opdenacker@free-electrons.com, poeschel@lemonage.de, andreas.noever@gmail.com, arnd@arndb.de, bp@suse.de, devicetree@vger.kernel.org, james.hogan@imgtec.com, pawel.moll@arm.com, linux-arm-msm@vger.kernel.org, sharon.dvir1@mail.huji.ac.il, robh+dt@kernel.org, sdharia@codeaurora.org, alan@linux.intel.com, treding@nvidia.com, mathieu.poirier@linaro.org, jkosina@suse.cz, linux-kernel@vger.kernel.org, daniel@ffwll.ch, joe@perches.com, davem@davemloft.net Subject: Re: [alsa-devel] [PATCH v7 05/13] slimbus: core: add support to device tree helper Message-ID: <20171117071104.GL3187@localhost> References: <20171115141043.29202-1-srinivas.kandagatla@linaro.org> <20171115141043.29202-6-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171115141043.29202-6-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2017 at 02:10:35PM +0000, srinivas.kandagatla@linaro.org wrote: > + > + for_each_child_of_node(ctrl->dev->of_node, node) { > + struct slim_device *sbdev; > + struct slim_eaddr e_addr; > + const char *compat = NULL; > + int reg[2], ret; > + int manf_id, prod_code; > + > + compat = of_get_property(node, "compatible", NULL); > + if (!compat) > + continue; > + > + ret = sscanf(compat, "slim%x,%x", &manf_id, &prod_code); > + if (ret != 2) { > + dev_err(dev, "Manf ID & Product code not found %s\n", > + compat); > + continue; > + } can we do xxx_property_read_u32() on compat and then use bit manupliations to get ids rather than scanf. > + > + ret = of_property_read_u32_array(node, "reg", reg, 2); I typically prefer using device_property_read_u32() but then this is of_ code so I will leave this upto you... -- ~Vinod