From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757941AbdKQNfa (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 08:35:30 -0500
Received: from mga01.intel.com ([192.55.52.88]:65224 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756986AbdKQNfW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 08:35:22 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,409,1505804400"; 
   d="scan'208";a="2726669"
Date: Fri, 17 Nov 2017 15:35:18 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>, heikki.krogerus@linux.intel.com,
        linux-gpio@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Endless Linux Upstreaming Team <linux@endlessm.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad
Message-ID: <20171117133518.GF17200@lahna.fi.intel.com>
References: <CAD8Lp47LZs6qbd00CDeX4s-eQkqf1dGO9VaFXuCaReQ2yE73Og@mail.gmail.com>
 <20171116115244.GQ17200@lahna.fi.intel.com>
 <CAD8Lp46fz-80hsOY1b4BFSHrr15Pk8nhYbaFh7MA0hquVSSc4g@mail.gmail.com>
 <20171116130743.GT17200@lahna.fi.intel.com>
 <CAB4CAwcqxBJNnaS9q7S7dy_1GoR5m1VHY89y+8g-G7rXBBJ1hg@mail.gmail.com>
 <20171117091134.GB17200@lahna.fi.intel.com>
 <CAB4CAwdsAXqb-2KQr3s1Z6UBJoBXwrks41qY5S8va=zz3UQ1hA@mail.gmail.com>
 <CAB4CAwfGsjtfZxHVvdyEAooqqK0whJS0MFZSsbm8+E0fi=hJyg@mail.gmail.com>
 <20171117110057.GD17200@lahna.fi.intel.com>
 <CAB4CAwcELV0LWeeBCP9MYt0i=W2sy_Cspwm2vD3K8az+hApQ3g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB4CAwcELV0LWeeBCP9MYt0i=W2sy_Cspwm2vD3K8az+hApQ3g@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 17, 2017 at 09:21:48PM +0800, Chris Chiu wrote:
> On Fri, Nov 17, 2017 at 7:00 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote:
> >> Hi Mika,
> >>     Here's the full dmesg log you need. The touchpad stop reporting at
> >> the last of the log.
> >> https://gist.github.com/mschiu77/a0b8d24a586a228c55eca30c87c71d41
> >
> > Thanks!
> >
> > I did not spot anything suspicious in the i2c-hid initialization. When
> > the issue happens, can you check what the pin state is and if it changes
> > when you use the touchpad? If I read your ACPI tables right, something
> > like this:
> >
> >   # grep GPIO_18 /sys/kernel/debug/pinctrl/INT3452:00/pins
> >
> > (it could be another INT3452:* device as well).
> >
> > The GPIO line should be high and when the touchpad is pressed it should
> > go low.
> >
> > Then another thing, if you unload i2c-hid and load it back, does it
> > start working again?
> >
> >   # modprobe -r i2c-hid
> >   # modprobe i2c-hid
> 
> Yup. We did the same inspection on /sys/kernel/debug/pinctrl/INT3452:00/pins
> before and after the touchpad stop working.
> Before touchpad stop working, most of the results would be
> pin 18 (GPIO_18) GPIO 0x40900102 0x00024075
> After touchpad stop working, the result would always be
> pin 18 (GPIO_18) GPIO 0x40900100 0x00024075

OK, so the line (as being active low) gets pulled to low and is never
released back.

Does /proc/interrupts show that the interrupt counts are still
increasing (for both the GPIO driver and the touchpad)?