From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759547AbdKQROD convert rfc822-to-8bit (ORCPT ); Fri, 17 Nov 2017 12:14:03 -0500 Received: from muru.com ([72.249.23.125]:49156 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbdKQRNt (ORCPT ); Fri, 17 Nov 2017 12:13:49 -0500 Date: Fri, 17 Nov 2017 09:13:45 -0800 From: Tony Lindgren To: Sebastian Reichel Cc: Arvind Yadav , kishon@ti.com, robh@kernel.org, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error checking. Message-ID: <20171117171345.GP28152@atomide.com> References: <115b1328cd921849e8a3dd1832c21a3de59aa0e0.1510917723.git.arvind.yadav.cs@gmail.com> <20171117123517.jjdia6dwccta5ojp@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20171117123517.jjdia6dwccta5ojp@earth> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sebastian Reichel [171117 12:37]: > Hi, > > On Fri, Nov 17, 2017 at 04:55:35PM +0530, Arvind Yadav wrote: > > The platform_get_irq_byname() function returns negative if an error occurs. > > zero or positive number on success. platform_get_irq_byname() error > > checking for zero is not correct. > > > > Signed-off-by: Arvind Yadav > > --- > > Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support") > Reviewed-by: Sebastian Reichel Acked-by: Tony Lindgren