From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759612AbdKQRTR (ORCPT ); Fri, 17 Nov 2017 12:19:17 -0500 Received: from bmailout1.hostsharing.net ([83.223.95.100]:49401 "EHLO bmailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbdKQRTM (ORCPT ); Fri, 17 Nov 2017 12:19:12 -0500 Date: Fri, 17 Nov 2017 18:19:09 +0100 From: Lukas Wunner To: Linus Torvalds Cc: Nicolai =?iso-8859-1?Q?H=E4hnle?= , LKML , dri-devel Subject: Re: [git pull] drm for v4.15 Message-ID: <20171117171909.GA15582@wunner.de> References: <26729c32-cfd6-82e0-b370-a46ca951adea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2017 at 08:57:53AM -0800, Linus Torvalds wrote: > On Fri, Nov 17, 2017 at 4:51 AM, Nicolai Hähnle wrote: > To see the effects of this, I picked something at random from one of > those huge AMD header files. > > I swear. It was entirely at random, and the first thing I picked. Do this: > > git grep PCIE_UNCORR_ERR_MASK Oh that looks familiar, it's the Uncorrectable Error Mask Register (PCIe Base Spec r2.1 page 558). We already have those definitions in the tree in include/uapi/linux/pci_regs.h: git grep PCI_ERR_UNC_ > and tell me that there isn't any room for making these things smarter. ... or deduplicate them. :-) Lukas