From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966823AbdKQUlI (ORCPT ); Fri, 17 Nov 2017 15:41:08 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:47866 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966545AbdKQUjY (ORCPT ); Fri, 17 Nov 2017 15:39:24 -0500 Date: Fri, 17 Nov 2017 12:39:22 -0800 From: Darren Hart To: Mario Limonciello Cc: Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix Message-ID: <20171117203922.GG22250@fury> References: <1510891992-31659-1-git-send-email-mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510891992-31659-1-git-send-email-mario.limonciello@dell.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 10:13:12PM -0600, Mario Limonciello wrote: > The Dell SMBIOS WMI interface will fail for some more complex calls unless > a WMI hotfix has been included. Most platforms have this fix available in > a maintenance BIOS release. In the case the driver is loaded on a > platform without this fix, disable the userspace interface. > > A hotfix indicator is present in the dell-wmi-descriptor that represents > whether or not more complex calls will work properly. > > "Simple" calls such as those used by dell-laptop and dell-wmi will continue > to work properly so dell-smbios-wmi should not be blocked from binding and > being used as the dell-smbios dispatcher. > > Suggested-by: Girish Prakash > Signed-off-by: Mario Limonciello Queued up, thanks Mario. -- Darren Hart VMware Open Source Technology Center