Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions

James Morris
2017-11-13T23:42:33Z

On Mon, 13 Nov 2017, Jarkko Sakkinen wrote:

> +
> + secs_epc = sgx_alloc_page(0);

Use SGX_ALLOC_ATOMIC instead of 0 ?

> + if (IS_ERR(secs_epc)) {
> + ret = PTR_ERR(secs_epc);
> + goto out;
> + }

> +out:
> + if (encl)
> + kref_put(&encl->refcount, sgx_encl_release);
> + return ret;
> +}

Don't you need an sgx_free_page() somewhere here?

--
James Morris
<james.l.morris@oracle.com>