Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions

Jarkko Sakkinen
2017-11-16T13:58:00Z

On Tue, Nov 14, 2017 at 10:12:25PM +0200, Jarkko Sakkinen wrote:
> On Tue, Nov 14, 2017 at 10:41:50AM +1100, James Morris wrote:
> > > + if (IS_ERR(secs_epc)) {
> > > + ret = PTR_ERR(secs_epc);
> > > + goto out;
> > > + }
> >
> > > +out:
> > > + if (encl)
> > > + kref_put(&encl->refcount, sgx_encl_release);
> > > + return ret;
> > > +}
> >
> > Don't you need an sgx_free_page() somewhere here?
>
> It will get freed by sgx_encl_release().

The call flow was somewhat messy so I just moved sgx_encl_alloc() call
outside of sgx_encl_create().

/Jarkko