From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764612AbdKRK02 (ORCPT ); Sat, 18 Nov 2017 05:26:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51160 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764595AbdKRK0T (ORCPT ); Sat, 18 Nov 2017 05:26:19 -0500 Date: Sat, 18 Nov 2017 11:26:21 +0100 From: Greg KH To: David Kershner Cc: jes.sorensen@gmail.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com, erik.arfvidson@gmail.com, wadgaonkarsam@gmail.com Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging Message-ID: <20171118102621.GE8368@kroah.com> References: <1510939659-15039-1-git-send-email-david.kershner@unisys.com> <1510939659-15039-3-git-send-email-david.kershner@unisys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510939659-15039-3-git-send-email-david.kershner@unisys.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0 > .../staging/unisys/include => include/linux/visorbus}/visorchannel.h | 0 Do we really need two different include/linux .h files for this bus subsystem? Can we merge them both together? > diff --git a/drivers/staging/unisys/visorbus/Kconfig b/drivers/visorbus/Kconfig > similarity index 90% > rename from drivers/staging/unisys/visorbus/Kconfig > rename to drivers/visorbus/Kconfig > index 5113880..a99285a 100644 > --- a/drivers/staging/unisys/visorbus/Kconfig > +++ b/drivers/visorbus/Kconfig > @@ -4,7 +4,9 @@ > > config UNISYS_VISORBUS > tristate "Unisys visorbus driver" > - depends on UNISYSSPAR > + depends on X86_64 && !UML > + select PCI > + select ACPI Wait, what? Why are you messing with the dependancies now? And never do a select if at all possible, do a 'depends on' instead. And why not UML? What about other arches, why are you now restricting it? That's an odd change to be doing here in a "move this out of staging" patch... thanks, greg k-h