From: Benson Leung <bleung@google.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages
Date: Sat, 18 Nov 2017 22:17:41 -0800 [thread overview]
Message-ID: <20171119061741.GB51565@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <1510670608-19594-2-git-send-email-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
Hi Jon,
On Tue, Nov 14, 2017 at 02:43:28PM +0000, Jon Hunter wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Acked-by: Benson Leung <bleung@chromium.org>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-11-19 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 14:43 [PATCH V2 1/2] mfd: cros ec: spi: Don't send first message too soon Jon Hunter
2017-11-14 14:43 ` [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages Jon Hunter
2017-11-14 18:47 ` Doug Anderson
2017-11-19 6:17 ` Benson Leung [this message]
2017-11-14 18:46 ` [PATCH V2 1/2] mfd: cros ec: spi: Don't send first message too soon Doug Anderson
2017-11-19 6:09 ` Benson Leung
2017-11-28 16:25 ` Jon Hunter
2017-11-29 11:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119061741.GB51565@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shawnn@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox