From: Jonathan Cameron <jic23@kernel.org>
To: Paolo Cretaro <paolocretaro@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, gwendal@chromium.org,
enric.balletbo@collabora.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: cros_ec: Remove unused variables
Date: Sun, 19 Nov 2017 10:32:51 +0000 [thread overview]
Message-ID: <20171119103251.17e666b2@archlinux> (raw)
In-Reply-To: <20171119005745.12192-1-paolocretaro@gmail.com>
On Sun, 19 Nov 2017 01:57:45 +0100
Paolo Cretaro <paolocretaro@gmail.com> wrote:
> Fix gcc warnings about variable 'ec_device' being set but not used
> in these files:
> common/cros_ec_sensors/cros_ec_sensors.c:194:25
> light/cros_ec_light_prox.c:184:25
>
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
(at some point soonish) for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 --
> drivers/iio/light/cros_ec_light_prox.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> index ed8063f2da99..7d30c59da3e2 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> @@ -191,7 +191,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> - struct cros_ec_device *ec_device;
> struct iio_dev *indio_dev;
> struct cros_ec_sensors_state *state;
> struct iio_chan_spec *channel;
> @@ -201,7 +200,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev)
> dev_warn(&pdev->dev, "No CROS EC device found.\n");
> return -EINVAL;
> }
> - ec_device = ec_dev->ec_dev;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*state));
> if (!indio_dev)
> diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c
> index b2a46b390d5c..acfad4aeb27a 100644
> --- a/drivers/iio/light/cros_ec_light_prox.c
> +++ b/drivers/iio/light/cros_ec_light_prox.c
> @@ -181,7 +181,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> - struct cros_ec_device *ec_device;
> struct iio_dev *indio_dev;
> struct cros_ec_light_prox_state *state;
> struct iio_chan_spec *channel;
> @@ -191,7 +190,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev)
> dev_warn(dev, "No CROS EC device found.\n");
> return -EINVAL;
> }
> - ec_device = ec_dev->ec_dev;
>
> indio_dev = devm_iio_device_alloc(dev, sizeof(*state));
> if (!indio_dev)
prev parent reply other threads:[~2017-11-19 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 0:57 [PATCH] iio: cros_ec: Remove unused variables Paolo Cretaro
2017-11-19 10:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119103251.17e666b2@archlinux \
--to=jic23@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolocretaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox