From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750917AbdKSKc6 (ORCPT ); Sun, 19 Nov 2017 05:32:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:35976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbdKSKc4 (ORCPT ); Sun, 19 Nov 2017 05:32:56 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2862C2186A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 19 Nov 2017 10:32:51 +0000 From: Jonathan Cameron To: Paolo Cretaro Cc: knaack.h@gmx.de, lars@metafoo.de, gwendal@chromium.org, enric.balletbo@collabora.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: cros_ec: Remove unused variables Message-ID: <20171119103251.17e666b2@archlinux> In-Reply-To: <20171119005745.12192-1-paolocretaro@gmail.com> References: <20171119005745.12192-1-paolocretaro@gmail.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Nov 2017 01:57:45 +0100 Paolo Cretaro wrote: > Fix gcc warnings about variable 'ec_device' being set but not used > in these files: > common/cros_ec_sensors/cros_ec_sensors.c:194:25 > light/cros_ec_light_prox.c:184:25 > > Signed-off-by: Paolo Cretaro Applied to the togreg branch of iio.git and pushed out as testing (at some point soonish) for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 -- > drivers/iio/light/cros_ec_light_prox.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > index ed8063f2da99..7d30c59da3e2 100644 > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > @@ -191,7 +191,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent); > - struct cros_ec_device *ec_device; > struct iio_dev *indio_dev; > struct cros_ec_sensors_state *state; > struct iio_chan_spec *channel; > @@ -201,7 +200,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev) > dev_warn(&pdev->dev, "No CROS EC device found.\n"); > return -EINVAL; > } > - ec_device = ec_dev->ec_dev; > > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*state)); > if (!indio_dev) > diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c > index b2a46b390d5c..acfad4aeb27a 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -181,7 +181,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent); > - struct cros_ec_device *ec_device; > struct iio_dev *indio_dev; > struct cros_ec_light_prox_state *state; > struct iio_chan_spec *channel; > @@ -191,7 +190,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev) > dev_warn(dev, "No CROS EC device found.\n"); > return -EINVAL; > } > - ec_device = ec_dev->ec_dev; > > indio_dev = devm_iio_device_alloc(dev, sizeof(*state)); > if (!indio_dev)