From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750911AbdKSL2Z (ORCPT ); Sun, 19 Nov 2017 06:28:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:42524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbdKSL2X (ORCPT ); Sun, 19 Nov 2017 06:28:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6EF21908 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 19 Nov 2017 11:28:19 +0000 From: Jonathan Cameron To: Eugen Hristev Cc: , , , , , , , Subject: Re: [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: ack DRDY irq in direct mode Message-ID: <20171119112819.5d128c3f@archlinux> In-Reply-To: <1510750608-8697-5-git-send-email-eugen.hristev@microchip.com> References: <1510750608-8697-1-git-send-email-eugen.hristev@microchip.com> <1510750608-8697-5-git-send-email-eugen.hristev@microchip.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Nov 2017 14:56:48 +0200 Eugen Hristev wrote: > Need to acknowledge DRDY irq in direct mode/ software > triggered mode. Otherwise, on the next conversion, overrun > flag will be raised, which is not a correct state. > This doesn't affect the functionality, but will generate > possible incorrect overrun reports. > > Signed-off-by: Eugen Hristev Applied. Thanks. > --- > drivers/iio/adc/at91-sama5d2_adc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 11d34a8..274cb5e 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -787,6 +787,9 @@ static int at91_adc_read_raw(struct iio_dev *indio_dev, > at91_adc_writel(st, AT91_SAMA5D2_IDR, BIT(chan->channel)); > at91_adc_writel(st, AT91_SAMA5D2_CHDR, BIT(chan->channel)); > > + /* Needed to ACK the DRDY interruption */ > + at91_adc_readl(st, AT91_SAMA5D2_LCDR); > + > mutex_unlock(&st->lock); > > iio_device_release_direct_mode(indio_dev);