public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tim Hansen <devtimhansen@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fs: Safe rcu access to hlist.
Date: Sun, 19 Nov 2017 21:28:49 +0000	[thread overview]
Message-ID: <20171119212849.GV21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171119200210.hhrklgm6hxhoyhqh@debian>

On Sun, Nov 19, 2017 at 03:02:10PM -0500, Tim Hansen wrote:
> Adds hlist_first_rcu and hlist_next_rcu for safe access
> to the hlist in seq_hlist_next_rcu.
> 
> Found on linux-next branch, tag next-20171117 with sparse.

Frankly, I'm tempted to take sparse RCU annotations out for good -
they are far too noisy and I'm not sure sparse is suitable for the
analysis needed to prove safety of that stuff, so unless you (or
somebody else) figures out how to use them in a reasonably clean
way, we'd probably be better off just dropping them.

  reply	other threads:[~2017-11-19 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19 20:02 [PATCH] fs: Safe rcu access to hlist Tim Hansen
2017-11-19 21:28 ` Al Viro [this message]
2017-11-20 18:55   ` Tim Hansen
2017-11-20 20:01     ` Luc Van Oostenryck
2017-11-20 20:42       ` Matthew Wilcox
2017-11-20 20:58         ` Luc Van Oostenryck
2017-11-20 21:21           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171119212849.GV21978@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=devtimhansen@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox