From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbdKSXXW (ORCPT ); Sun, 19 Nov 2017 18:23:22 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:36494 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdKSXXV (ORCPT ); Sun, 19 Nov 2017 18:23:21 -0500 X-Auth-Info: fEgquY6h6Ejx0M0ubhhAUFP2VsTvz8LoYGAnnkdK+Dw= Date: Mon, 20 Nov 2017 00:23:07 +0100 From: Lukasz Majewski To: Alexander Sverdlin Cc: Hartley Sweeten , Arnd Bergmann , arndbergmann@gmail.com, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Olof Johansson , Linus Walleij Subject: Re: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Message-ID: <20171120002307.0694ed35@jawa> In-Reply-To: <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com> References: <20171116232239.16823-1-lukma@denx.de> <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com> Organization: denx.de X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/XLa06jCV7X3J5BrVQ.aFcYM"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/XLa06jCV7X3J5BrVQ.aFcYM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Alexander, > Hello Lukasz! >=20 > On 17/11/17 00:22, Lukasz Majewski wrote: > > This patch series adds support for Liebherr's BK3 board, being > > a derivative of TS72XX design. > >=20 > > This patchset consists of following patches: > >=20 > > - ts72xx.[c|h] cosmetic cleanup/improvement > > - Move the common code for ts72xx and BK3 to ts72xx-common.c - this > > code can be reused by other designs build around ts72xx > > - The Liebherr's BK3 board has been added with re-using code of > > ts72xx.c > >=20 > > Lukasz Majewski (4): > > ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable =20 >=20 > The patch 3/4 deletes everything added by patch 1/4, so I don't > really see the point of it. I wanted to first clean up things. >=20 > > ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file > > ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board > > ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx > > derivative =20 >=20 > I tend to agree with Hartley, if you'd just add all BK3-related > extras to ts72xx.c it would be less than 60 LoCs, you probably even > do not need new Kconfig options. Some Kconfig option would be welcome (MACH_BK3 ?) if it turns out that I do need to adjust some things later (like change HAMMING NAND ECC to BCH for plat_nand driver). The separate bk3.c file is more appealing (for me) in terms of extending the code latter. >=20 > Alex. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de --Sig_/XLa06jCV7X3J5BrVQ.aFcYM Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAloSElwACgkQAR8vZIA0 zr30rgf/QOe0fa3Hqzwx2NAVYGNKw3ho37iSgBkCiQ96H2nCDsIuSR61qx6TLdSM XUk7At7X5frSjMbF/gcIiag05gT/4sqPAjlbAfpdpCyWswjHiZOv/KWfMq886X4I zfr6gJ1xlS7k4hT12MeS7y+YeYlOn154EdpWE8USEnqcU61tcBi9UjQB5krIotEC nFIoUL0tuQyRK2hvaR6cIWt+8KyRQroadfEpnA6olp4FegSXOCLSO6skeBUBzytv 6Lr0VtyKBtY04ZiqZI+QjF9+2AYyUsg5L4ivA0UztGVJLFmYBwCoq2H6Tohn1ntG FE04klwScCheVGhWYUrCKZkzunn2lg== =3xta -----END PGP SIGNATURE----- --Sig_/XLa06jCV7X3J5BrVQ.aFcYM--