* [PATCH] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
@ 2017-11-20 7:02 Jesse Chan
2017-11-20 7:12 ` Greg Kroah-Hartman
2017-11-20 7:50 ` [PATCH v2] " Jesse Chan
0 siblings, 2 replies; 6+ messages in thread
From: Jesse Chan @ 2017-11-20 7:02 UTC (permalink / raw)
Cc: Jesse Chan, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
devel, linux-kernel
Signed-off-by: Jesse Chan <jc@linux.com>
---
drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c57332..b61d56367773 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
.detach = ni_atmio_detach,
};
module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 7:02 [PATCH] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
@ 2017-11-20 7:12 ` Greg Kroah-Hartman
2017-11-20 7:50 ` [PATCH v2] " Jesse Chan
1 sibling, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-11-20 7:12 UTC (permalink / raw)
To: Jesse Chan; +Cc: Ian Abbott, H Hartley Sweeten, devel, linux-kernel
On Sun, Nov 19, 2017 at 11:02:52PM -0800, Jesse Chan wrote:
> Signed-off-by: Jesse Chan <jc@linux.com>
I can't take patches without any changelog text :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 7:02 [PATCH] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
2017-11-20 7:12 ` Greg Kroah-Hartman
@ 2017-11-20 7:50 ` Jesse Chan
2017-11-20 10:29 ` Ian Abbott
1 sibling, 1 reply; 6+ messages in thread
From: Jesse Chan @ 2017-11-20 7:50 UTC (permalink / raw)
Cc: Jesse Chan, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
devel, linux-kernel
This change resolves a new compile-time warning
when built as a loadable module:
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o
see include/linux/module.h for more information
This adds the license as "GPL", which matches the header of the file.
MODULE_DESCRIPTION is also added.
Signed-off-by: Jesse Chan <jc@linux.com>
---
drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 2d62a8c57332..b61d56367773 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
.detach = ni_atmio_detach,
};
module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 7:50 ` [PATCH v2] " Jesse Chan
@ 2017-11-20 10:29 ` Ian Abbott
2017-11-20 10:46 ` Ian Abbott
0 siblings, 1 reply; 6+ messages in thread
From: Ian Abbott @ 2017-11-20 10:29 UTC (permalink / raw)
To: Jesse Chan; +Cc: H Hartley Sweeten, Greg Kroah-Hartman, devel, linux-kernel
On 20/11/17 07:50, Jesse Chan wrote:
> This change resolves a new compile-time warning
> when built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o
> see include/linux/module.h for more information
>
> This adds the license as "GPL", which matches the header of the file.
>
> MODULE_DESCRIPTION is also added.
>
> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 2d62a8c57332..b61d56367773 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
> .detach = ni_atmio_detach,
> };
> module_comedi_driver(ni_atmio_driver);
> +
> +MODULE_DESCRIPTION("Comedi low-level driver");
> +MODULE_LICENSE("GPL");
Thanks! I wonder how I managed to miss out this driver in commit
3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI
modules")?
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 10:29 ` Ian Abbott
@ 2017-11-20 10:46 ` Ian Abbott
2017-11-22 7:04 ` Matthew Giassa
0 siblings, 1 reply; 6+ messages in thread
From: Ian Abbott @ 2017-11-20 10:46 UTC (permalink / raw)
To: Jesse Chan; +Cc: H Hartley Sweeten, Greg Kroah-Hartman, devel, linux-kernel
On 20/11/17 10:29, Ian Abbott wrote:
> On 20/11/17 07:50, Jesse Chan wrote:
>> This change resolves a new compile-time warning
>> when built as a loadable module:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in
>> drivers/staging/comedi/drivers/ni_atmio.o
>> see include/linux/module.h for more information
>>
>> This adds the license as "GPL", which matches the header of the file.
>>
>> MODULE_DESCRIPTION is also added.
>>
>> Signed-off-by: Jesse Chan <jc@linux.com>
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
>> b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 2d62a8c57332..b61d56367773 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
>> .detach = ni_atmio_detach,
>> };
>> module_comedi_driver(ni_atmio_driver);
>> +
>> +MODULE_DESCRIPTION("Comedi low-level driver");
>> +MODULE_LICENSE("GPL");
>
> Thanks! I wonder how I managed to miss out this driver in commit
> 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI
> modules")?
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Despite my above comment, we should probably give precedence to Matthew
Giassa's patch for the same issue, since it was sent earlier.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 10:46 ` Ian Abbott
@ 2017-11-22 7:04 ` Matthew Giassa
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Giassa @ 2017-11-22 7:04 UTC (permalink / raw)
To: Ian Abbott
Cc: Jesse Chan, H Hartley Sweeten, Greg Kroah-Hartman, devel,
linux-kernel
* Ian Abbott <abbotti@mev.co.uk> [2017-11-20 10:46:36 +0000]:
>On 20/11/17 10:29, Ian Abbott wrote:
>>On 20/11/17 07:50, Jesse Chan wrote:
>>>This change resolves a new compile-time warning
>>>when built as a loadable module:
>>>
>>>WARNING: modpost: missing MODULE_LICENSE() in
>>>drivers/staging/comedi/drivers/ni_atmio.o
>>>see include/linux/module.h for more information
>>>
>>>This adds the license as "GPL", which matches the header of the file.
>>>
>>>MODULE_DESCRIPTION is also added.
>>>
>>>Signed-off-by: Jesse Chan <jc@linux.com>
>>>---
>>> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>>diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
>>>b/drivers/staging/comedi/drivers/ni_atmio.c
>>>index 2d62a8c57332..b61d56367773 100644
>>>--- a/drivers/staging/comedi/drivers/ni_atmio.c
>>>+++ b/drivers/staging/comedi/drivers/ni_atmio.c
>>>@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
>>> .detach = ni_atmio_detach,
>>> };
>>> module_comedi_driver(ni_atmio_driver);
>>>+
>>>+MODULE_DESCRIPTION("Comedi low-level driver");
>>>+MODULE_LICENSE("GPL");
>>
>>Thanks! I wonder how I managed to miss out this driver in commit
>>3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI
>>modules")?
>>
>>Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
>Despite my above comment, we should probably give precedence to
>Matthew Giassa's patch for the same issue, since it was sent earlier.
>
>--
>-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
>-=( Web: http://www.mev.co.uk/ )=-
--
Thanks. Also, this one should probably include the MODULE_AUTHOR macro
as well.
Cheers!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-22 7:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 7:02 [PATCH] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
2017-11-20 7:12 ` Greg Kroah-Hartman
2017-11-20 7:50 ` [PATCH v2] " Jesse Chan
2017-11-20 10:29 ` Ian Abbott
2017-11-20 10:46 ` Ian Abbott
2017-11-22 7:04 ` Matthew Giassa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox