From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbdKTJ0x (ORCPT ); Mon, 20 Nov 2017 04:26:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32798 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdKTJ0w (ORCPT ); Mon, 20 Nov 2017 04:26:52 -0500 Date: Mon, 20 Nov 2017 10:26:48 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads Message-ID: <20171120092648.GA30958@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 20 Nov 2017 09:26:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:35PM +0800, Jin Yao wrote: > perf stat --per-thread is useful to break down data per thread. > But it currently requires specifying --pid/--tid to limit it to a process. > > For analysis it would be useful to do it globally for the whole system. I can't compile this: builtin-script.c: In function ‘perf_sample__fprint_metric’: builtin-script.c:1549:2: error: too few arguments to function ‘perf_stat__update_shadow_stats’ perf_stat__update_shadow_stats(evsel, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from builtin-script.c:24:0: util/stat.h:134:6: note: declared here void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 count, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ builtin-script.c:1555:4: error: too few arguments to function ‘perf_stat__print_shadow_stats’ perf_stat__print_shadow_stats(ev2, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from builtin-script.c:24:0: util/stat.h:143:6: note: declared here void perf_stat__print_shadow_stats(struct perf_evsel *evsel, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mv: cannot stat './.builtin-script.o.tmp': No such file or directory thanks, jirka