From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751149AbdKTM34 (ORCPT ); Mon, 20 Nov 2017 07:29:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53172 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdKTM3z (ORCPT ); Mon, 20 Nov 2017 07:29:55 -0500 Date: Mon, 20 Nov 2017 13:29:52 +0100 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads Message-ID: <20171120122952.GA12500@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <20171120092648.GA30958@krava> <4fa51069-25b0-f53b-b0fa-34320445e2b4@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4fa51069-25b0-f53b-b0fa-34320445e2b4@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 20 Nov 2017 12:29:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 08:15:56PM +0800, Jin, Yao wrote: > > > On 11/20/2017 5:26 PM, Jiri Olsa wrote: > > On Mon, Nov 20, 2017 at 10:43:35PM +0800, Jin Yao wrote: > > > perf stat --per-thread is useful to break down data per thread. > > > But it currently requires specifying --pid/--tid to limit it to a process. > > > > > > For analysis it would be useful to do it globally for the whole system. > > > > I can't compile this: > > > > builtin-script.c: In function ‘perf_sample__fprint_metric’: > > builtin-script.c:1549:2: error: too few arguments to function ‘perf_stat__update_shadow_stats’ > > perf_stat__update_shadow_stats(evsel, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from builtin-script.c:24:0: > > util/stat.h:134:6: note: declared here > > void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 count, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > builtin-script.c:1555:4: error: too few arguments to function ‘perf_stat__print_shadow_stats’ > > perf_stat__print_shadow_stats(ev2, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from builtin-script.c:24:0: > > util/stat.h:143:6: note: declared here > > void perf_stat__print_shadow_stats(struct perf_evsel *evsel, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > mv: cannot stat './.builtin-script.o.tmp': No such file or directory > > > > thanks, > > jirka > > > > Hi Jiri, > > This patch set is based on the latest perf/core branch. > > I pull the branch right now and try the build again, the building is OK. > > Could you tell me which branch you are testing on? ugh.. I was over Andi's changes.. I'll recheck sry for noise jirka