From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbdKTOog (ORCPT ); Mon, 20 Nov 2017 09:44:36 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:39398 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbdKTOof (ORCPT ); Mon, 20 Nov 2017 09:44:35 -0500 X-Auth-Info: z/+/1pHPM3t0/UW+oTg4Xi73nYKK2ags29W8W92skwE= Date: Mon, 20 Nov 2017 15:44:19 +0100 From: Lukasz Majewski To: Arnd Bergmann Cc: Alexander Sverdlin , Hartley Sweeten , Russell King , Linux ARM , Linux Kernel Mailing List , Olof Johansson , Linus Walleij Subject: Re: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Message-ID: <20171120154419.16ec57ca@jawa> In-Reply-To: References: <20171116232239.16823-1-lukma@denx.de> <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com> <20171120002307.0694ed35@jawa> Organization: denx.de X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/=EmNJ9t+N7rW60Q_rGfBX9M"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/=EmNJ9t+N7rW60Q_rGfBX9M Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Arnd, > On Mon, Nov 20, 2017 at 12:23 AM, Lukasz Majewski > wrote: > > Hi Alexander, > > =20 > >> Hello Lukasz! > >> > >> On 17/11/17 00:22, Lukasz Majewski wrote: =20 > >> > This patch series adds support for Liebherr's BK3 board, being > >> > a derivative of TS72XX design. > >> > > >> > This patchset consists of following patches: > >> > > >> > - ts72xx.[c|h] cosmetic cleanup/improvement > >> > - Move the common code for ts72xx and BK3 to ts72xx-common.c - > >> > this code can be reused by other designs build around ts72xx > >> > - The Liebherr's BK3 board has been added with re-using code of > >> > ts72xx.c > >> > > >> > Lukasz Majewski (4): > >> > ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where > >> > applicable =20 > >> > >> The patch 3/4 deletes everything added by patch 1/4, so I don't > >> really see the point of it. =20 > > > > I wanted to first clean up things. =20 >=20 > Cleaning it up first is the right approach, a patch that moves code > around should not contain any other changes. >=20 > >> > ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file > >> > ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board > >> > ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx > >> > derivative =20 > >> > >> I tend to agree with Hartley, if you'd just add all BK3-related > >> extras to ts72xx.c it would be less than 60 LoCs, you probably even > >> do not need new Kconfig options. =20 > > > > Some Kconfig option would be welcome (MACH_BK3 ?) if it turns out > > that I do need to adjust some things later (like change HAMMING > > NAND ECC to BCH for plat_nand driver). > > > > The separate bk3.c file is more appealing (for me) in terms of > > extending the code latter. =20 >=20 > I think keeping everything in one file, but adding a new Kconfig > option that uses 'select MACH_TS72XX' to enable the existing board > would be simpler, we can split it out later once we think it gets too > big. Ok. Thanks for the suggestion. I will prepare v2. >=20 > Arnd Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de --Sig_/=EmNJ9t+N7rW60Q_rGfBX9M Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAloS6kMACgkQAR8vZIA0 zr1Sigf+POboc5yS+PYr4HgXOxAcFEhK6fSI5S00GQDiXKmo7lSJItQWNPy19ra6 y+L6C2RW9YEA2cYSogQHMOrD5l1W3yzfL9FvFJ7oF2Jlil+xUPHV9SR3Y8SJXiK7 /F/nrSnu5z4J/movTaIfASuAiqqFsZPJUkOxLH6+bDI//gVgET/H8NITJZR+DJUR vMd8VvxFs/oM1zXJwWtDO1RVGMBrAt9X5J/idvhzR7ZlHC7+3DNvxlxcpryES0Ku l7c6HW1PHTipbJaWwtOHegnPJ313kjUp9wJTe1Yy/9LU2lajnhUk5TiKbwIfw6/Z IZvk/kltqGahahpmCHvcIfF4cuyXgw== =tNcI -----END PGP SIGNATURE----- --Sig_/=EmNJ9t+N7rW60Q_rGfBX9M--