From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbdKTPrA (ORCPT ); Mon, 20 Nov 2017 10:47:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34396 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbdKTPq6 (ORCPT ); Mon, 20 Nov 2017 10:46:58 -0500 Date: Mon, 20 Nov 2017 16:46:55 +0100 From: Jiri Olsa To: SF Markus Elfring Cc: Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Namhyung Kim , Peter Zijlstra , David Ahern , Kan Liang , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config() Message-ID: <20171120154655.GA13495@krava> References: <50004e9c-14f8-5a01-fa96-001d32e7c2b2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50004e9c-14f8-5a01-fa96-001d32e7c2b2@users.sourceforge.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 20 Nov 2017 15:46:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 04:30:13PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 20 Nov 2017 15:55:25 +0100 > > Duplicate error messages were used so far in this function implementation. > Make them unique instead. > > This issue was detected by using the Coccinelle software. > > Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events") > Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data") > Signed-off-by: Markus Elfring Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/builtin-stat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 59af5a8419e2..ed0f23bb2230 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe) > if (counter->own_cpus) { > err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event); > if (err < 0) { > - pr_err("Couldn't synthesize evsel scale.\n"); > + pr_err("Couldn't synthesize evsel CPUs.\n"); > return err; > } > } > @@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe) > err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus, > process_synthesized_event, NULL); > if (err < 0) { > - pr_err("Couldn't synthesize thread map.\n"); > + pr_err("Couldn't synthesize CPU map.\n"); > return err; > } > > -- > 2.15.0 >