* [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config()
@ 2017-11-20 15:30 SF Markus Elfring
2017-11-20 15:46 ` Jiri Olsa
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-11-20 15:30 UTC (permalink / raw)
To: Alexander Shishkin, Arnaldo Carvalho de Melo, Ingo Molnar,
Jiri Olsa, Namhyung Kim, Peter Zijlstra
Cc: David Ahern, Kan Liang, kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 20 Nov 2017 15:55:25 +0100
Duplicate error messages were used so far in this function implementation.
Make them unique instead.
This issue was detected by using the Coccinelle software.
Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events")
Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
tools/perf/builtin-stat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 59af5a8419e2..ed0f23bb2230 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
if (counter->own_cpus) {
err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event);
if (err < 0) {
- pr_err("Couldn't synthesize evsel scale.\n");
+ pr_err("Couldn't synthesize evsel CPUs.\n");
return err;
}
}
@@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus,
process_synthesized_event, NULL);
if (err < 0) {
- pr_err("Couldn't synthesize thread map.\n");
+ pr_err("Couldn't synthesize CPU map.\n");
return err;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config()
2017-11-20 15:30 [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config() SF Markus Elfring
@ 2017-11-20 15:46 ` Jiri Olsa
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Olsa @ 2017-11-20 15:46 UTC (permalink / raw)
To: SF Markus Elfring
Cc: Alexander Shishkin, Arnaldo Carvalho de Melo, Ingo Molnar,
Namhyung Kim, Peter Zijlstra, David Ahern, Kan Liang,
kernel-janitors, LKML
On Mon, Nov 20, 2017 at 04:30:13PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 20 Nov 2017 15:55:25 +0100
>
> Duplicate error messages were used so far in this function implementation.
> Make them unique instead.
>
> This issue was detected by using the Coccinelle software.
>
> Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events")
> Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data")
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/perf/builtin-stat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 59af5a8419e2..ed0f23bb2230 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
> if (counter->own_cpus) {
> err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event);
> if (err < 0) {
> - pr_err("Couldn't synthesize evsel scale.\n");
> + pr_err("Couldn't synthesize evsel CPUs.\n");
> return err;
> }
> }
> @@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
> err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus,
> process_synthesized_event, NULL);
> if (err < 0) {
> - pr_err("Couldn't synthesize thread map.\n");
> + pr_err("Couldn't synthesize CPU map.\n");
> return err;
> }
>
> --
> 2.15.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 15:30 [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config() SF Markus Elfring
2017-11-20 15:46 ` Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox