Re: [PATCH] watchdog: eurotechwdt: mark expected switch fall-through

Guenter Roeck
2017-11-20T17:44:28Z

On Mon, Nov 20, 2017 at 11:06:45AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "Fall" with a proper
> "fall through" comment, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/eurotechwdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/eurotechwdt.c b/drivers/watchdog/eurotechwdt.c
> index 38e9671..47f77a6 100644
> --- a/drivers/watchdog/eurotechwdt.c
> +++ b/drivers/watchdog/eurotechwdt.c
> @@ -290,7 +290,7 @@ static long eurwdt_ioctl(struct file *file,
> eurwdt_timeout = time;
> eurwdt_set_timeout(time);
> spin_unlock(&eurwdt_lock);
> - /* Fall */
> + /* fall through */
>
> case WDIOC_GETTIMEOUT:
> return put_user(eurwdt_timeout, p);
> --
> 2.7.4
>