From: Darren Hart <dvhart@infradead.org>
To: Mario.Limonciello@dell.com
Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix
Date: Mon, 20 Nov 2017 12:37:49 -0800 [thread overview]
Message-ID: <20171120203749.GA5421@fury> (raw)
In-Reply-To: <4f2192b6a6ed4764b5645efa7f6f2a54@ausx13mpc120.AMER.DELL.COM>
On Mon, Nov 20, 2017 at 04:03:53PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@infradead.org]
> > Sent: Friday, November 17, 2017 2:39 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; LKML <linux-
> > kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace
> > interface if missing hotfix
> >
> > On Thu, Nov 16, 2017 at 10:13:12PM -0600, Mario Limonciello wrote:
> > > The Dell SMBIOS WMI interface will fail for some more complex calls unless
> > > a WMI hotfix has been included. Most platforms have this fix available in
> > > a maintenance BIOS release. In the case the driver is loaded on a
> > > platform without this fix, disable the userspace interface.
> > >
> > > A hotfix indicator is present in the dell-wmi-descriptor that represents
> > > whether or not more complex calls will work properly.
> > >
> > > "Simple" calls such as those used by dell-laptop and dell-wmi will continue
> > > to work properly so dell-smbios-wmi should not be blocked from binding and
> > > being used as the dell-smbios dispatcher.
> > >
> > > Suggested-by: Girish Prakash <girish.prakash@dell.com>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> >
> > Queued up, thanks Mario.
>
> Darren, even though this came after the merge windows opened considering this
> restricts the SMBIOS interface from some platform/firmware combinations it
> shouldn't be offered, do you think this can be included with a future 4.15
> RCx PR so it can land with the rest of the series rather than targeted for 4.16?
This will make 4.15.
>
> I'd hate to get stuck in a situation that an interface deemed "broken" gets offered
> to people it shouldn't.
>
Agreed.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-11-20 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 4:13 [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix Mario Limonciello
2017-11-17 20:39 ` Darren Hart
2017-11-20 16:03 ` Mario.Limonciello
2017-11-20 20:37 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120203749.GA5421@fury \
--to=dvhart@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox