From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbdKTUki (ORCPT ); Mon, 20 Nov 2017 15:40:38 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:45658 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbdKTUkh (ORCPT ); Mon, 20 Nov 2017 15:40:37 -0500 X-Google-Smtp-Source: AGs4zMYXm1DKFed87jVHJv+8XLp5rxxppzDUx6+tNaesWl/1nkSDvDukHdSa22RlY5ebGO/5v6CrCw== Date: Mon, 20 Nov 2017 23:40:33 +0300 From: Alexey Dobriyan To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, akinobu.mita@gmail.com Subject: [PATCH] proc: don't use READ_ONCE/WRITE_ONCE for /proc/*/fail-nth Message-ID: <20171120204033.GA9446@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org READ_ONCE and WRITE_ONCE are useless when there is only one read/write is being made. Signed-off-by: Alexey Dobriyan --- fs/proc/base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1371,7 +1371,7 @@ static ssize_t proc_fail_nth_write(struct file *file, const char __user *buf, task = get_proc_task(file_inode(file)); if (!task) return -ESRCH; - WRITE_ONCE(task->fail_nth, n); + task->fail_nth = n; put_task_struct(task); return count; @@ -1387,8 +1387,7 @@ static ssize_t proc_fail_nth_read(struct file *file, char __user *buf, task = get_proc_task(file_inode(file)); if (!task) return -ESRCH; - len = snprintf(numbuf, sizeof(numbuf), "%u\n", - READ_ONCE(task->fail_nth)); + len = snprintf(numbuf, sizeof(numbuf), "%u\n", task->fail_nth); len = simple_read_from_buffer(buf, count, ppos, numbuf, len); put_task_struct(task);