* [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE
@ 2017-11-20 21:33 Jesse Chan
2017-11-20 22:06 ` Bjorn Andersson
2017-11-21 19:19 ` Subhash Jadavani
0 siblings, 2 replies; 3+ messages in thread
From: Jesse Chan @ 2017-11-20 21:33 UTC (permalink / raw)
Cc: Jesse Chan, Kishon Vijay Abraham I, Vivek Gautam,
Subhash Jadavani, Bjorn Andersson, Yoshihiro Shimoda,
linux-kernel
This change resolves a new compile-time warning
when built as a loadable module:
WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
see include/linux/module.h for more information
This adds the license as "GPL v2", which matches the header of the file.
MODULE_DESCRIPTION is also added.
Signed-off-by: Jesse Chan <jc@linux.com>
---
drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
index c5ff4525edef..124dc70f6986 100644
--- a/drivers/phy/qualcomm/phy-qcom-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
@@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
return 0;
}
EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
+
+MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
+MODULE_LICENSE("GPL v2");
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 21:33 [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
@ 2017-11-20 22:06 ` Bjorn Andersson
2017-11-21 19:19 ` Subhash Jadavani
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2017-11-20 22:06 UTC (permalink / raw)
To: Jesse Chan
Cc: Kishon Vijay Abraham I, Vivek Gautam, Subhash Jadavani,
Yoshihiro Shimoda, linux-kernel
On Mon 20 Nov 13:33 PST 2017, Jesse Chan wrote:
> This change resolves a new compile-time warning
> when built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> see include/linux/module.h for more information
>
> This adds the license as "GPL v2", which matches the header of the file.
>
> MODULE_DESCRIPTION is also added.
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Although I suspect that the plan was for the three ufs phy drivers to be
one kernel module...
Regards,
Bjorn
> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
> drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..124dc70f6986 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
> return 0;
> }
> EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE
2017-11-20 21:33 [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
2017-11-20 22:06 ` Bjorn Andersson
@ 2017-11-21 19:19 ` Subhash Jadavani
1 sibling, 0 replies; 3+ messages in thread
From: Subhash Jadavani @ 2017-11-21 19:19 UTC (permalink / raw)
To: Jesse Chan
Cc: Kishon Vijay Abraham I, Vivek Gautam, Bjorn Andersson,
Yoshihiro Shimoda, linux-kernel
On 2017-11-20 13:33, Jesse Chan wrote:
> This change resolves a new compile-time warning
> when built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/phy/qualcomm/phy-qcom-ufs.o
> see include/linux/module.h for more information
>
> This adds the license as "GPL v2", which matches the header of the
> file.
>
> MODULE_DESCRIPTION is also added.
>
> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
> drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c
> b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..124dc70f6986 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
> return 0;
> }
> EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-21 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 21:33 [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE Jesse Chan
2017-11-20 22:06 ` Bjorn Andersson
2017-11-21 19:19 ` Subhash Jadavani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).