From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751242AbdKTWGx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 17:06:53 -0500
Received: from mail-pf0-f194.google.com ([209.85.192.194]:37348 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751131AbdKTWGv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 17:06:51 -0500
X-Google-Smtp-Source: AGs4zMb/HyLpaRuXyj1Kgnc5WrCjkmH/KckZMAXj4K0Oxdu1/IiOIrOF6O/g+FBU8Q1YQnRQ54wCrQ==
Date: Mon, 20 Nov 2017 14:06:47 -0800
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jesse Chan <jc@linux.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        Vivek Gautam <vivek.gautam@codeaurora.org>,
        Subhash Jadavani <subhashj@codeaurora.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE
Message-ID: <20171120220647.GB28761@minitux>
References: <20171120213305.53913-1-jc@linux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171120213305.53913-1-jc@linux.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 20 Nov 13:33 PST 2017, Jesse Chan wrote:

> This change resolves a new compile-time warning
> when built as a loadable module:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> see include/linux/module.h for more information
> 
> This adds the license as "GPL v2", which matches the header of the file.
> 
> MODULE_DESCRIPTION is also added.
> 

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Although I suspect that the plan was for the three ufs phy drivers to be
one kernel module...

Regards,
Bjorn

> Signed-off-by: Jesse Chan <jc@linux.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..124dc70f6986 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.14.1
>