From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751570AbdKTXlv (ORCPT ); Mon, 20 Nov 2017 18:41:51 -0500 Received: from mga01.intel.com ([192.55.52.88]:54418 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbdKTXlt (ORCPT ); Mon, 20 Nov 2017 18:41:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,430,1505804400"; d="scan'208";a="178648601" Date: Tue, 21 Nov 2017 01:41:45 +0200 From: Jarkko Sakkinen To: Borislav Petkov Cc: intel-sgx-kernel-dev@lists.01.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 11/11] intel_sgx: driver documentation Message-ID: <20171120234145.6bnm5s5ntevbzjfk@linux.intel.com> References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-12-jarkko.sakkinen@linux.intel.com> <20171114083647.uxlaov56s2xw3pua@pd.tnic> <20171114204948.f6g2m62kx5gr5xtw@linux.intel.com> <20171114215327.qiqze33uvhlu555g@pd.tnic> <20171120223741.52dj6gevcwn5jzag@linux.intel.com> <20171120224256.kz3qvz4ek6ky7ywc@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171120224256.kz3qvz4ek6ky7ywc@pd.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 11:42:56PM +0100, Borislav Petkov wrote: > On Tue, Nov 21, 2017 at 12:37:41AM +0200, Jarkko Sakkinen wrote: > > Firmware cannot access the memory inside an enclave. CPU asserts every > > memory access coming outside the enclave. > > But "firmware could potentially configure the root key hash for the > enclave." How about the owner configures the root key hash instead? > Along with deciding whether to lock down the feature control register or In potential deployments of SGX, the owner could do this either in the firmware level or OS level depending whether the MSRs are configured as writable in the feature control. One option would be to have a config flag to decide whether to require MSRs to be writable or not. /Jarkko