From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbdKUGGi (ORCPT ); Tue, 21 Nov 2017 01:06:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:43198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbdKUGGh (ORCPT ); Tue, 21 Nov 2017 01:06:37 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A7472187C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org Date: Tue, 21 Nov 2017 08:06:33 +0200 From: Leon Romanovsky To: Geert Uytterhoeven Cc: Yuval Shaia , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB: INFINIBAND should depend on HAS_DMA Message-ID: <20171121060633.GP18825@mtr-leonro.local> References: <1511117910-25003-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RzVoCur9CYlE2OzC" Content-Disposition: inline In-Reply-To: <1511117910-25003-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RzVoCur9CYlE2OzC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined! > ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined! > ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined! > ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined! > > Before, this was handled implicitly by the dependency on PCI. > Add an explicit dependency on HAS_DMA to fix this. > > Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs") > Signed-off-by: Geert Uytterhoeven > --- > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky --RzVoCur9CYlE2OzC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloTwmkACgkQ5GN7iDZy WKfcDRAAmIlLoxIlg/niFzfoctxhbI7CDEF8YbXup+YtWKMY358idcxiEJml6dgP HVPljYAqrftmUkhFVgNoUmYjIwu+vx6BSumE8a1MYNAkqfLp+p3ihVnCIZcOkH27 46ntJ2JSDRBaU+TH1yqCqbUZeUtgCAB9JgNoPVZanQ8qJWRCF5Wl4it4mI/9vBPN zK141Dtiu+T3urp3Gf1Bff6U7q3q4Zz3SelWJliMC0PjIr0xHxszCHzpY1i23jEJ Hn5ejOoHQDu7A1PJEgGes5kYdb0BlfaWmWqrnYIbrh0+5Ppt+8OZ7UHP8RofrjTU m34FLQL9/ctSmFv0vr9BaUSdqWfb4WtIm9VyaKyu0Cb3hnImmDfS9ZEpByN+ZdcN nUbZZPgVOVqRFbDFqdMjEgeQE4Nl1W9TskP1C4ahCWSYiUMnTq0Pm9B68gzI+hAt Ln08+GroUVP3Psbmf10/TYmwG3gEbpBVdkahkPcUzsI7fBzDl9AgPz0d/oWC+lNE GNAAiWecmW8oN4BpkFoFyYqy9/FbQZUUjxV8NcZ9rGgN1Xiz+Iyzcs3noMd9RonD fVE7U8LRz4OzDkJ+GRiA6o2X+114pPXBvJ3lAPksSJ7/V7Ty0ssc7yCQEKte17Mg oOJDHCgmAC628IvVThjIcezU5c8a0iyHL91L3/GGsDlGk8CNBIU= =todi -----END PGP SIGNATURE----- --RzVoCur9CYlE2OzC--