From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: luca abeni <luca.abeni@santannapisa.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Juri Lelli <juri.lelli@arm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Galbraith <efault@gmx.de>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: Use bools for the state flags
Date: Tue, 21 Nov 2017 14:06:30 +0100 [thread overview]
Message-ID: <20171121130630.GG3165@worktop.lehotels.local> (raw)
In-Reply-To: <nycvar.YFH.7.76.1711211142300.11505@cbobk.fhfr.pm>
On Tue, Nov 21, 2017 at 11:44:05AM +0100, Jiri Kosina wrote:
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -473,10 +473,10 @@ struct sched_dl_entity {
> * conditions between the inactive timer handler and the wakeup
> * code.
> */
> - int dl_throttled : 1;
> - int dl_boosted : 1;
> - int dl_yielded : 1;
> - int dl_non_contending : 1;
> + bool dl_throttled;
> + bool dl_boosted;
> + bool dl_yielded;
> + bool dl_non_contending;
NAK, don't ever use _Bool in composite types.
prev parent reply other threads:[~2017-11-21 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 10:44 [PATCH] sched/deadline: Use bools for the state flags Jiri Kosina
2017-11-21 10:52 ` Thomas Gleixner
2017-11-21 11:43 ` Jiri Kosina
2017-11-21 12:00 ` [PATCH v2] sched/deadline: Use unsigned type " Jiri Kosina
2017-11-21 16:22 ` Ingo Molnar
2017-11-21 12:56 ` [PATCH] sched/deadline: Use bools " Steven Rostedt
2017-11-21 15:53 ` Linus Torvalds
2017-11-21 10:56 ` Luca Abeni
2017-11-21 13:06 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121130630.GG3165@worktop.lehotels.local \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=efault@gmx.de \
--cc=jikos@kernel.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox