From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbdKUPRT (ORCPT ); Tue, 21 Nov 2017 10:17:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56480 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdKUPRR (ORCPT ); Tue, 21 Nov 2017 10:17:17 -0500 Date: Tue, 21 Nov 2017 16:17:14 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats Message-ID: <20171121151714.GC20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 Nov 2017 15:17:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote: > In current stat-shadow.c, the rblist deleting is ignored. > > The patch reconstructs the codes of rblist init/free, and adds > the implementation to node_delete method of rblist. > > This patch also does: > > 1. Add the ctx/type/stat into rbtree keys because we will > use this rbtree to maintain shadow metrics to replace original > a couple of static arrays for supporting per-thread shadow stats. > > 2. Create a static runtime_stat variable 'rt_stat' which > will log the shadow metrics by default. please make that separate patches then, one patch - one logical change thanks, jirka