From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbdKUPRZ (ORCPT ); Tue, 21 Nov 2017 10:17:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56536 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdKUPRX (ORCPT ); Tue, 21 Nov 2017 10:17:23 -0500 Date: Tue, 21 Nov 2017 16:17:20 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats Message-ID: <20171121151720.GD20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 Nov 2017 15:17:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote: SNIP > +static void init_saved_rblist(struct rblist *rblist) > +{ > + rblist__init(rblist); > + rblist->node_cmp = saved_value_cmp; > + rblist->node_new = saved_value_new; > + rblist->node_delete = saved_value_delete; > +} > + > +static void free_saved_rblist(struct rblist *rblist) > +{ > + rblist__reset(rblist); > +} > + > +void perf_stat__init_runtime_stat(struct runtime_stat *stat) > +{ > + memset(stat, 0, sizeof(struct runtime_stat)); > + init_saved_rblist(&stat->value_list); > +} > + > +void perf_stat__free_runtime_stat(struct runtime_stat *stat) > +{ > + free_saved_rblist(&stat->value_list); > +} > + > void perf_stat__init_shadow_stats(void) > { > have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend"); > - rblist__init(&runtime_saved_values); > - runtime_saved_values.node_cmp = saved_value_cmp; > - runtime_saved_values.node_new = saved_value_new; > - /* No delete for now */ > + memset(&walltime_nsecs_stats, 0, sizeof(walltime_nsecs_stats)); why do you zero walltime_nsecs_stats in here? jirka