From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbdKUPSE (ORCPT ); Tue, 21 Nov 2017 10:18:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38380 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdKUPSD (ORCPT ); Tue, 21 Nov 2017 10:18:03 -0500 Date: Tue, 21 Nov 2017 16:18:00 +0100 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 4/9] perf util: Update and print per-thread shadow stats Message-ID: <20171121151800.GI20440@krava> References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511189024-19908-5-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 21 Nov 2017 15:18:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 10:43:39PM +0800, Jin Yao wrote: SNIP > if (num == 0) > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c > index 151e9ef..50bb16d 100644 > --- a/tools/perf/util/stat.c > +++ b/tools/perf/util/stat.c > @@ -278,9 +278,16 @@ process_counter_values(struct perf_stat_config *config, struct perf_evsel *evsel > perf_evsel__compute_deltas(evsel, cpu, thread, count); > perf_counts_values__scale(count, config->scale, NULL); > if (config->aggr_mode == AGGR_NONE) > - perf_stat__update_shadow_stats(evsel, count->val, cpu); > - if (config->aggr_mode == AGGR_THREAD) > - perf_stat__update_shadow_stats(evsel, count->val, 0); > + perf_stat__update_shadow_stats(evsel, count->val, cpu, > + NULL); > + if (config->aggr_mode == AGGR_THREAD) { > + if (config->stats) > + perf_stat__update_shadow_stats(evsel, > + count->val, 0, &config->stats[thread]); please add this part together with config->stats allocation/usage and keep this change only about adding the struct runtime_stat *stat into the code path with no functional change thanks, jirka